Closed Bug 989449 Opened 10 years ago Closed 10 years ago

Dropmarker corners do not have border-radius on Windows 7, Vista and XP

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Version:
31 Branch
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 31
Tracking Flags:
Tracking Status
firefox29 --- verified
firefox30 --- verified
firefox31 --- verified

People

(Reporter: thalesplsantos, Assigned: ntim)

References

(Blocks 1 open bug)

Details

(Keywords: regression, Whiteboard: [Australis:P3-])

Attachments

(2 files)

bug.png
(deleted), image/png
Details
Patch v1
(deleted), patch
mikedeboer
: review+
Sylvestre
: approval-mozilla-aurora+
Sylvestre
: approval-mozilla-beta+
Details | Diff | Splinter Review
Attached image bug.png (deleted) — 
Dropmarker buttons are lacking the 2px border-radius in topright and bottomright corners.
Mike, any chance this is because of the recent fix for open menu buttons?
Flags: needinfo?(mdeboer)
I'm pretty sure this is a regression, just not sure from when...
Blocks: australis-cust
Keywords: regression, regressionwindow-wanted
Whiteboard: [Australis:P3]
Whiteboard: [Australis:P3] → [Australis:P3-]
I noticed this bug on Windows XP as well.
Assignee: nobody → ntim007
Status: NEW → ASSIGNED
Summary: Dropmarker corners do not have border-radius → Dropmarker corners do not have border-radius on Windows 7, Vista and XP
Attached patch Patch v1 (deleted) — — Splinter Review 
Can someone test this patch for me ?
Attachment #8398907 - Flags: review?(mdeboer)
Comment on attachment 8398907 [details] [diff] [review]
Patch v1

Review of attachment 8398907 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM! No side-effect, tested on Win 8, 7 & XP.
Attachment #8398907 - Flags: review?(mdeboer) → review+
Keywords: checkin-needed
Whiteboard: [Australis:P3-] → [Australis:P3-][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/74d802ab25c3
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P3-][fixed-in-fx-team] → [Australis:P3-]
Target Milestone: --- → Firefox 31
Comment on attachment 8398907 [details] [diff] [review]
Patch v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: Missing round corners
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Low risk
String or IDL/UUID changes made by this patch: None
Attachment #8398907 - Flags: approval-mozilla-beta?
Attachment #8398907 - Flags: approval-mozilla-aurora?
Attachment #8398907 - Flags: approval-mozilla-beta?
Attachment #8398907 - Flags: approval-mozilla-beta+
Attachment #8398907 - Flags: approval-mozilla-aurora?
Attachment #8398907 - Flags: approval-mozilla-aurora+
Keywords: checkin-needed
Mike, last I knew, your team was still handling the Australis uplifts. Can you please get this landed on Aurora/Beta?
status-firefox31: affected → fixed
Flags: needinfo?(mdeboer)
Keywords: checkin-needed
The border-radius is now correctly displayed on Windows 7 32bit, Windows 7 64bit, Windows Vista 32bit and Windows XP 32bit using:
- latest Nightly build - 20140407030203,
- latest Firefox Aurora build - 20140407004002 and
- Firefox 29 beta 6 - build ID: 20140407135746.
Status: RESOLVED → VERIFIED
status-firefox29: fixed → verified
status-firefox30: fixed → verified
status-firefox31: fixed → verified
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: