David Baron :dbaron: Assignee
	Description • 10 years ago

I just did an audit to check that all {ref,crash}test{,s}.list files have an include line in a manifest (potentially skip-if() or in at least one case even commented out).  I found a number that weren't, and a few that were included more than once.

(Bug 989574 made me realize I should check this.)

	David Baron :dbaron: Assignee
	Comment 1 • 10 years ago

https://tbpl.mozilla.org/?tree=Try&rev=b547341da57b

	David Baron :dbaron: Assignee
	Comment 2 • 10 years ago

er, again: https://tbpl.mozilla.org/?tree=Try&rev=9101a133ef70

	David Baron :dbaron: Assignee
	Comment 3 • 10 years ago

These duplicate lines were added in two changesets with only one
changeset between them:
https://hg.mozilla.org/mozilla-central/rev/08afb5a033eb
https://hg.mozilla.org/mozilla-central/rev/79b61f9909c0

	David Baron :dbaron: Assignee
	Comment 4 • 10 years ago

This should have been added in
https://hg.mozilla.org/mozilla-central/rev/a888be20e9d7 (bug 975931).

	David Baron :dbaron: Assignee
	Comment 5 • 10 years ago

This should have been added in
https://hg.mozilla.org/mozilla-central/rev/7fa9d642fe74 (bug 596515).

jhk, do you still happen to have a copy of the missing
form-dynamic-not-invalid-barred.html file?

	David Baron :dbaron: Assignee
	Comment 6 • 10 years ago

All three lines were added in
https://hg.mozilla.org/mozilla-central/rev/2eb1331a2bc4

	David Baron :dbaron: Assignee
	Comment 7 • 10 years ago

This should have been added in
https://hg.mozilla.org/mozilla-central/rev/745c0c2aa1fe (bug 464339).

Furthermore, the image being missing was the result of using
checkin-needed on a non-GIT-style diff "containing" an image.

	David Baron :dbaron: Assignee
	Comment 8 • 10 years ago

This should have been added in
https://hg.mozilla.org/mozilla-central/rev/0c2c2c895e5d (bug 442419) or
perhaps also in bug 841001 when another test was added to this
directory.

	(not currently active) Ted Mielczarek
	Comment 9 • 10 years ago

We could probably add some sort of build-time test for this: get the full list of manifests included from the root manifest, and also trawl the source tree for the full list of manifests present and make sure they match.

	Gregory Szorc [:gps]
	Comment 10 • 10 years ago

I think it's only a matter of time before we hook reftests up to the build system like we have done with xpcshell tests and mochitests. That should enable all kinds of auditing potential. AFAIK that bug hasn't been filed yet. It likely isn't a pressing concern.

	Jignesh Kakadiya [:jhk]
	Comment 11 • 10 years ago

 
> jhk, do you still happen to have a copy of the missing
> form-dynamic-not-invalid-barred.html file?

Nope. Going through the patch again it looks like I missed this file in patch in bug 596515. May be some one else added this file later.

https://hg.mozilla.org/mozilla-central/rev/7fa9d642fe74

	Robert O'Callahan (:roc) (email my personal email if necessary)
	Comment 12 • 10 years ago

Comment on attachment 8399101 [details] [diff] [review]
patch 2 - Run the reftests in layout/reftests/async-scrolling/

Review of attachment 8399101 [details] [diff] [review]:
-----------------------------------------------------------------

oooops

	David Baron :dbaron: Assignee
	Comment 13 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/43295cbce602
https://hg.mozilla.org/integration/mozilla-inbound/rev/5448dc1939df
https://hg.mozilla.org/integration/mozilla-inbound/rev/755856a2f096
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca4d53859c96
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfaf3e711f26
https://hg.mozilla.org/integration/mozilla-inbound/rev/ada9f861cd50

	Carsten Book [:Tomcat]
	Comment 14 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/43295cbce602
https://hg.mozilla.org/mozilla-central/rev/5448dc1939df
https://hg.mozilla.org/mozilla-central/rev/755856a2f096
https://hg.mozilla.org/mozilla-central/rev/ca4d53859c96
https://hg.mozilla.org/mozilla-central/rev/dfaf3e711f26
https://hg.mozilla.org/mozilla-central/rev/ada9f861cd50