Closed
Bug 989907
Opened 11 years ago
Closed 11 years ago
initialize AudioNodeExternalInputStream output chunk even when first track has null output
Categories
(Core :: Web Audio, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: karlt, Assigned: karlt)
References
(Depends on 1 open bug)
Details
Attachments
(2 files)
|
(deleted),
patch
|
roc
:
review+
karlt
:
checkin+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Sometimes content/media/webaudio/test/test_mediaElementAudioSourceNode.html
content/media/test/crashtests/media-element-source-seek-1.html hit
http://hg.mozilla.org/mozilla-central/annotate/382f676d0ed9/content/media/AudioNodeExternalInputStream.cpp#l447
when i == 0, which would suggest uninitialized memory contributing to or in
mLastChunks.
This might be the cause of bug 974232 and the click reported in bug 944924 comment 6.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8399269 -
Flags: review?(roc)
Attachment #8399269 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
I started making test_mediaElementAudioSourceNode.html more precise, which would detect one bad block here, but bug 983062 means that the output is too short and so the extra bad block is not detected. There are other ways to be more precise but bug 983023 would then make such tests fail. Let's try again once those bugs are fixed.
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 8399269 [details] [diff] [review]
patch
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8cf49d6d296
Attachment #8399269 -
Flags: checkin+
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•