Closed
Bug 990021
Opened 11 years ago
Closed 10 years ago
[Messages] We should show the correct error message when trying to download a MMS in airplane mode
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(tracking-b2g:backlog)
RESOLVED
FIXED
tracking-b2g | backlog |
People
(Reporter: julienw, Assigned: azasypkin)
References
Details
(Whiteboard: [priority][sms-sprint-2.1S1])
Attachments
(1 file)
We need to display a different message for RadioDisabledError in the MMS retrieving case. +++ This bug was initially created as a clone of Bug #981577 +++ STR: * set "MMS Automatic retrieval" to off * receive a MMS with attachment * enable airplane mode * try to download the MMS Expected: * we should see an error related to airplane mode Actual: * no error is displayed, only the error icon is added. Note that I didn't find any error message related to airplane mode for this case (we have one for _sending_ messages but it's not suited for this bug). NI ayman for providing more information. QAwanted to know the behavior in v1.1.
Reporter | ||
Comment 1•11 years ago
|
||
NI Joe because we need to prioritize this in the 1.5 time frame.
Flags: needinfo?(jcheng)
Comment 2•11 years ago
|
||
1.5? so this can be triaged in comms team triage
blocking-b2g: --- → 1.5?
Flags: needinfo?(jcheng)
Comment 3•11 years ago
|
||
Change component to SMS, if it's not correct, please assign back or assign to correct component, thanks.
Component: RIL → Gaia::SMS
Comment 5•11 years ago
|
||
triage: add to backlog ni? Omega for the spec
blocking-b2g: 2.0? → backlog
Flags: needinfo?(ofeng)
Comment 6•11 years ago
|
||
Let's use this: Airplane Mode Activated ----------------------- Turn off airplane mode to download attachments. [OK]
Flags: needinfo?(ofeng)
Comment 7•11 years ago
|
||
Hi Omega, Do you have other strings to notify user instead of guiding them to turning off airplane mode?
Flags: needinfo?(ofeng)
Whiteboard: [priority]
Comment 8•11 years ago
|
||
(In reply to Wesley Huang [:wesley_huang] from comment #7) > Hi Omega, > Do you have other strings to notify user instead of guiding them to turning > off airplane mode? I suggest this string since we have similar string when sending MSG with Airplane mode on. It's "Turn off airplane mode to send messages.". If we want to change the string, we should consider both of them. No idea for now. Anybody has suggestions?
Flags: needinfo?(ofeng)
Reporter | ||
Comment 9•10 years ago
|
||
I think that when Airplane mode is enabled, the user will know how to disable it.
Assignee | ||
Comment 10•10 years ago
|
||
Hey Omega and Julien, Currently I see the following message for the STR in comment 0: Title: "Airplane mode activated" Body: "Turn off airplane mode to send messages." - still a bit weird, as we're not sending anything, but retrieving. Should we just replace "send message" part with "download message" or there are any other ideas? Thanks!
Flags: needinfo?(ofeng)
Assignee | ||
Comment 14•10 years ago
|
||
Hey Steve, I have the patch for this for a long time already, but was waiting for bug 1035279 to be resolved, so the time to dust off this code has come :) Thanks!
Comment 15•10 years ago
|
||
Patch looks fine for me but I haven't got a validate sim for testing yet, will try it other day. Thanks!
Comment 16•10 years ago
|
||
Comment on attachment 8465283 [details]
GitHub pull request URL
Thanks for adding new error message for this case. I think we just need additional comment for this, so r=me.
Attachment #8465283 -
Flags: review?(schung) → review+
Assignee | ||
Comment 17•10 years ago
|
||
(In reply to Steve Chung [:steveck] from comment #16) > Comment on attachment 8465283 [details] > GitHub pull request URL > > Thanks for adding new error message for this case. I think we just need > additional comment for this, so r=me. Thanks for review! Added comment as you suggested. Master: https://github.com/mozilla-b2g/gaia/commit/9d6c9c846721d9f7ff44c5f1421fb202e1d0b640
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Whiteboard: [priority] → [priority][sms-sprint-2.1S1]
Updated•10 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
You need to log in
before you can comment on or make changes to this bug.
Description
•