Do we have the visuals ready for this?

We had initial designs and visuals. However, as a result of the usability study feedback, Jacqueline is currently redesigning the screens. She will sync up with Sam early next week.

The need to use video snippets in 2.0, but keep the existing image sequence for tablets means this should build on the new generic & configurable tutorial work in bug 939174.

Summary of updates to tutorial flow are captured in this spec from :jsavory https://mozilla.app.box.com/s/m593btokr997r3o5ggvr

Preview video at: https://dl.dropboxusercontent.com/u/1719101/share/video-tutorials.MOV The quality isn't great but you should be able to make out the looping, the timing and the layout there. I'm a bit worried that some of the step titles will need more vertical room than we current make available. That video shows the Peak, other phones have less vertical space I think? Also, in some languages we can expect the text to grow and need > 2 lines. The mockups have removed the progress bar (is there consensus on that?) If we do that, then we get some space back which might help. It might be best to evaluate this in a separate bug and see if that needs to be brought into scope for 2.0?

ni jsavory too

Removing dependency on edge-gesture bug; we're only blocked on the configurable tutorial bug 1017314

WIP at https://github.com/sfoster/gaia/tree/bug-990035-video-tutorial

This is looking great! One thing - I noticed a weird flicker on the notifications video, is that a product of the video or from the code? Also, we might want to have a better transition for the other two videos. We could do something like a quick black fade, but I'm assuming its better to add that into the video itself. For the removal of the progress bar, I'm happy to have it as a separate bug as I don't think it is necessary for 2.0. ni? On Eric for the transition, and space for a third line of text.

(In reply to jsavory from comment #9) > This is looking great! > > One thing - I noticed a weird flicker on the notifications video, is that a > product of the video or from the code? Also, we might want to have a better > transition for the other two videos. We could do something like a quick > black fade, but I'm assuming its better to add that into the video itself. > > For the removal of the progress bar, I'm happy to have it as a separate bug > as I don't think it is necessary for 2.0. > > ni? On Eric for the transition, and space for a third line of text. I don't see the flicker on the video file, but I'll check while exporting the new version. I'll also add a fade to the vertical scroll and sheets vids and see what it looks like. If the progress bar is removed we should have enough space for strings in different locales. The text should be vertically centered between the top of the screen and the video.

(I'll let you fight over who gets to review this :) This PR adds video assets (placeholder, see bug 1019289), and updates the FTU tutorial and config to support video for the steps. Note that the large/tablet layout configured in large.json is not currently in-scope for changing in 2.0 so that is unchanged and the old images and strings are untouched for that reason. I have another patch queued up to get the update tutorial working (bug 990035 and bug 939174), but as that needs the revised tutorial assets also, I'd prefer to land this one first.

The video assets added here are about 2.5MB. In light of bug 1019321, I need to also remove the obsoleted images in this patch if at all possible. They total about ~400KB, though the build should only incude the relevant resolution images so in practice its less than that. I'm pretty worried this will get backed out for the same reason. I don't have a Buri to test on, I do have a tarako and open c (as well as a flame). Is either comparable? See also bug 1019289 where we'll land the final video assets - though we expect those to be in the same filesize ballpark.

I updated the PR to remove the orphaned images. The *_large.png are still there for the tablet as this tutorial config is unchanged

Comment on attachment 8432884 [details] PR bug-990035-video-tutorial Some comments in Github. Our Tutorial is stunning with these new videos! Please address the comments and ask me to review this again, we are quite close to land! Thanks

Can someone test the patch in the github link here to see if a Buri eng. build successfully flashes correctly & can be used?

Comment on attachment 8432884 [details] PR bug-990035-video-tutorial Addressed the nits in the PR. See also my comments in github in answer to a couple of your questions.

Comment on attachment 8432884 [details] PR bug-990035-video-tutorial Great job! Wait for Travis and let's land this! :)

https://github.com/sfoster/gaia/commit/fabeaffcc637780a490cfcca023aa33ee42041f4 https://github.com/mozilla-b2g/gaia/commit/31979e81157f4fda07b54cf72af5001581c06339 R+. Merged!

The removal of the progress bar is being tracked as bug 1019098.

Unfortunately I had to revert this for intermittent test failures: https://tbpl.mozilla.org/php/getParsedLog.php?id=41194761&tree=B2g-Inbound https://github.com/mozilla-b2g/gaia/commit/d98df93b7d4c060f19fc8bb0b1238a70012af15e

Flagging this as late-l10n, as we're branching/string-freezing on Monday. Also, I remember the sound of Sam's voice about "let's not plan to work over the weekend on Wednesday"

Comment on attachment 8432884 [details] PR bug-990035-video-tutorial https://github.com/mozilla-b2g/gaia/pull/20164

Opened a new PR. I couldn't reproduce this issue with the unit test timing out, but I did go in and fix some dubious error handling and refactor those tests to avoid the timeouts. So we should get actual test failures rather than ambiguous timeouts. Queued up travis build: https://travis-ci.org/mozilla-b2g/gaia/builds/26977780 Do you want to re-review this or should I carry the r+ and merge if travis is green?

Landed: https://github.com/mozilla-b2g/gaia/commit/5da8b7aa1038dab45fdfa8ea7f25109e86213c7a Try https://tbpl.mozilla.org/?tree=Gaia-Try&showall=1&rev=4ac98002b352 Travis: https://travis-ci.org/sfoster/gaia/jobs/26989254 I got just a couple of what appear to be perma-orange and unrelated test failures: test_homescreen_launch_app.py test_homescreen_launch_app.TestLaunchApp.test_launch_app test_a11y_unlock_to_homescreen.py test_a11y_unlock_to_homescreen.TestLockScreenAccessibility.test_a11y_unlock_to_homescreen

(In reply to Sam Foster [:sfoster] from comment #24) > Landed: > https://github.com/mozilla-b2g/gaia/commit/ > 5da8b7aa1038dab45fdfa8ea7f25109e86213c7a on my repo: https://github.com/sfoster/gaia/commit/05ba68961342501988d8d38c64d560d956beb44f I was not able to reproduce the unit test failures. But I've tightened up the tests and its been performing well. Fingers crossed I guess.

Let's hope that this sticks, removing the late-l10n keyword for now.

(In reply to Sam Foster [:sfoster] from comment #25) > I was not able to reproduce the unit test failures. But I've tightened up > the tests and its been performing well. Fingers crossed I guess. Thank you :-)

(In reply to Sam Foster [:sfoster] from comment #25) > I was not able to reproduce the unit test failures. But I've tightened up > the tests and its been performing well. Fingers crossed I guess. They're sadly still occurring: https://tbpl.mozilla.org/php/getParsedLog.php?id=41416128&tree=Fx-Team I tried to back this out but after having to back out at least two other bugs (and still getting conflicts), I've decided to file separately - please can you take a look at the test and disable it if you think you might not have the cycles for a while. Thanks :-)

This made 2.0.