Closed Bug 990255 Opened 11 years ago Closed 11 years ago

[Camera][Mozilla] 1.4 Zoom bar and indicators are too close to each other when rotated 180

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::Camera
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(b2g-v1.4 verified, b2g-v2.0 verified)

Status:
VERIFIED FIXED
Milestone:
1.4 S5 (11apr)
Tracking Flags:
Tracking Status
b2g-v1.4 --- verified
b2g-v2.0 --- verified

People

(Reporter: amylee, Assigned: wilsonpage)

References

Details

(Whiteboard: ux-tracking, visual design, jian [fxos:media][m?])

Attachments

(2 files)

Screen Shot 2014-03-31 at 5.19.15 PM.png
(deleted), image/png
Details
pull-request (master)
(deleted), text/x-github-pull-request
amylee
: ui-review+
Details
Checked on the master branch. When the camera is rotated 180 degrees, indicators should be 8px away from the edge of the screen. See attached. Thanks!
Blocks: 983405
No longer blocks: 971444
No longer blocks: 983405
Assignee: nobody → jdarcangelo
Blocks: 983405
Whiteboard: ux-tracking, visual design, jian [fxos:media] → ux-tracking, visual design, jian [fxos:media][m?]
Assignee: jdarcangelo → wilsonpage
Attached file pull-request (master) (deleted) —
Attachment #8400645 - Flags: ui-review?(amlee)
amlee: Indicators are 15px from edge, unless at 180deg, then 8px. Is that correct? Or do you want 8px at all times?
(In reply to Wilson Page [:wilsonpage] from comment #2) > amlee: Indicators are 15px from edge, unless at 180deg, then 8px. Is that > correct? Or do you want 8px at all times? "Indicators are 15px from edge, unless at 180deg, then 8px" This is correct :-)
Attachment #8400645 - Flags: ui-review?(amlee) → ui-review+
Landed on 'master': https://github.com/mozilla-b2g/gaia/commit/94999cc45f2c367a9bc613059e42c758342d96d3
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Bulk edit for camera bugs. If earlier comments do not show how this bug landed to master, it probably landed as part of https://github.com/mozilla-b2g/gaia/pull/17599 which merged the camera-new-features branch into master. This bug was uplifted from master to v1.4 as part of https://github.com/mozilla-b2g/gaia/commit/a8190d08e61316a86bba572ba8d894d081a20530
status-b2g-v1.4: --- → fixed
status-b2g-v2.0: --- → fixed
Target Milestone: --- → 1.4 S5 (11apr)
The bug is no longer reproduces on the latest 1.4 and master builds The zoom bar indicators are not too close to each other anymore and distance now as expected 1.4 Environmental Variables: Device: Buri 1.4 MOZ BuildID: 20140407000203 Gaia: 86de7fcce674ef6196d68e7e23552d219a3d72db Gecko: 6e028297be14 Version: 30.0a2 Firmware Version: v1.2-device.cfg 1.5 Environmental Variables: Device: Buri 1.5 MOZ BuildID: 20140407040202 Gaia: f1a98bfaa3ab2480945bd7018831fd56c61cdc24 Gecko: 5405d6f4e3c6 Version: 31.0a1 Firmware Version: v1.2-device.cfg
Status: RESOLVED → VERIFIED
status-b2g-v1.4: fixed → verified
status-b2g-v2.0: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: