Seperating the tabToolbarNavbarOverlap change out of bug 946987 since bug 990218 also wants it and it's good to do regardless of how bug 946987 ends up.

I forget exactly why I switched from margin-bottom to using background-position for bug 946987 but regardless adjusting the background-position makes sense to me.

Comment on attachment 8399794 [details] [diff] [review] v.1 Replace 1px with @tabToolbarNavbarOverlap@ (and one margin => background-position) Review of attachment 8399794 [details] [diff] [review]: ----------------------------------------------------------------- LGTM - thanks for factoring that stuff out.

Comment on attachment 8399794 [details] [diff] [review] v.1 Replace 1px with @tabToolbarNavbarOverlap@ (and one margin => background-position) [Approval Request Comment] Bug caused by (feature/regressing bug #): Multiple bugs using hardcoded "1px" User impact if declined: More fragile UI leading to potential breakages from future changes Testing completed (on m-c, etc.): m-c Risk to taking this patch (and alternatives if risky): Low risk mostly swapping hardcoded "1px" for a define String or IDL/UUID changes made by this patch: None

https://hg.mozilla.org/releases/mozilla-aurora/rev/0ceda75d3c5e https://hg.mozilla.org/releases/mozilla-beta/rev/a2fccb7d55f7