Closed
Bug 990566
Opened 11 years ago
Closed 10 years ago
Remove strings made unused by bug 738796
Categories
(Firefox :: Settings UI, defect)
Firefox
Settings UI
Tracking
()
People
(Reporter: dao, Assigned: nyee, Mentored)
References
()
Details
(Whiteboard: [good first bug])
Attachments
(1 file)
(deleted),
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
buttonForward.tooltip and buttonBack.tooltip are unused, haven't checked if there are more.
Comment 1•11 years ago
|
||
These may be used by bug 660726.
Updated•11 years ago
|
Flags: firefox-backlog?
Updated•11 years ago
|
Flags: firefox-backlog? → firefox-backlog+
Whiteboard: p=0
Reporter | ||
Comment 2•10 years ago
|
||
There's no recent progress in bug 660726. If and when that happens, it should just add the strings back as needed.
Mentor: dao
Whiteboard: p=0 → p=0 [good first bug]
Comment 4•10 years ago
|
||
You can follow the steps at https://developer.mozilla.org/En/Simple_Firefox_build to get build Firefox locally. Please join #introduction on the Mozilla IRC network (irc.mozilla.org) and people there can help you get your build environment up and running.
Assignee: nobody → alanaribeiroramos
Status: NEW → ASSIGNED
Comment 5•10 years ago
|
||
Hi Hanna, are you still able to work on this bug?
Flags: needinfo?(alanaribeiroramos)
Reporter | ||
Updated•10 years ago
|
Status: ASSIGNED → NEW
Updated•10 years ago
|
Flags: needinfo?(jaws)
Reporter | ||
Updated•10 years ago
|
Assignee: alanaribeiroramos → nobody
Updated•10 years ago
|
Flags: needinfo?(jaws)
Flags: needinfo?(alanaribeiroramos)
Updated•10 years ago
|
Points: --- → 1
Whiteboard: p=0 [good first bug] → [good first bug]
Is this bug assigned? I'm a newbie and I would like to fix this bug, if it is unassigned yet.
Reporter | ||
Comment 7•10 years ago
|
||
(In reply to agaurav77 from comment #6)
> Is this bug assigned? I'm a newbie and I would like to fix this bug, if it
> is unassigned yet.
It's currently unassigned.
Dao
I am new to bug fixing. What should I know beforehand? (I'm setting up a dev version according to https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Windows_Prerequisites) What IRC channels should I ask help on?
Thanks.
Reporter | ||
Comment 9•10 years ago
|
||
(In reply to agaurav77 from comment #8)
> Dao
>
> I am new to bug fixing. What should I know beforehand? (I'm setting up a dev
> version according to
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> Build_Instructions/Windows_Prerequisites) What IRC channels should I ask
> help on?
The #introduction channel on irc.mozilla.org should be a good place for asking for help.
Assignee | ||
Comment 10•10 years ago
|
||
I am interested in contributing to this bug. Where would the unused strings likely be?
Comment 11•10 years ago
|
||
you can use dxr (http://dxr.mozilla.org/) to search through the code base, just search for the strings reported in comment 0.
Reporter | ||
Comment 12•10 years ago
|
||
I also pointed to the file in this bug's URL field: http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/preferences/preferences.dtd
Assignee | ||
Comment 13•10 years ago
|
||
Attachment #8542656 -
Flags: review?(dao)
Reporter | ||
Comment 14•10 years ago
|
||
Comment on attachment 8542656 [details] [diff] [review]
bug-990566-fix.patch
Thanks!
Attachment #8542656 -
Flags: review?(dao) → review+
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → ny.nathan.yee
Keywords: checkin-needed
Comment 15•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [good first bug] → [good first bug][fixed-in-fx-team]
Comment 16•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][fixed-in-fx-team] → [good first bug]
Target Milestone: --- → Firefox 37
Updated•10 years ago
|
Iteration: --- → 37.3
Flags: qe-verify?
Reporter | ||
Updated•10 years ago
|
Flags: qe-verify? → qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•