Closed
Bug 990725
Opened 11 years ago
Closed 11 years ago
Support ErrorEvent.colno
Categories
(Core :: DOM: Events, defect)
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: crimsteam, Assigned: ayg)
References
Details
Attachments
(1 file)
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20140314220517
Steps to reproduce:
In FX 31 we got support ErrorEvent, but ErrorEvent.colno return undefined,
I see that it has been implemented ErrorEvent.column.
Chrome and IE using ErrorEvent.colno.
Link to HTML5: http://www.w3.org/html/wg/drafts/html/master/webappapis.html#the-errorevent-interface
Assignee | ||
Comment 1•11 years ago
|
||
WHATWG spec link: http://www.whatwg.org/specs/web-apps/current-work/multipage/webappapis.html#the-errorevent-interface
Bug 643325 called the property .column, apparently based on an old spec version. It was changed to .colno on July 25: http://lists.whatwg.org/htdig.cgi/commit-watchers-whatwg.org/2013/007234.html Probably someone was using one of the misleading outdated W3C spec versions, if those still exist. Sigh.
Looks like we should change this.
Assignee: nobody → ayg
Blocks: 643325
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 7 → All
Hardware: x86_64 → All
Assignee | ||
Comment 2•11 years ago
|
||
Testcase:
data:text/html,<!doctype html><body>
<script>document.body.textContent =
new ErrorEvent("x").column + " " +
new ErrorEvent("x").colno</script>
A nightly says "0 undefined". Chrome 34 says "undefined 0". The test fails in IE for some reason, but Hixie's whole reason for changing was to match IE, so I'll take his word for it that it does.
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #8410264 -
Flags: review?(bugs)
Reporter | ||
Comment 4•11 years ago
|
||
In IE fails because you use constructor (which IE has problems), but IE support ErrorEvent.colno.
Comment 5•11 years ago
|
||
Comment on attachment 8410264 [details] [diff] [review]
Patch
Tiny bit risky to just remove a property, but since it was added recently, hopefully this is ok.
Attachment #8410264 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Flags: in-testsuite+
Assignee | ||
Comment 7•11 years ago
|
||
(There was one additional test failure on try which I fixed locally before pushing, in dom/events/test/test_error_events.html.)
Comment 8•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•