Closed
Bug 991067
Opened 11 years ago
Closed 11 years ago
Cost control crashes after FTU steps mozilla::gfx::GetCairoSurfaceForSourceSurface(mozilla::gfx::SourceSurface*, bool)
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
People
(Reporter: Bebe, Assigned: mattwoodrow)
References
Details
(Keywords: crash, regression, reproducible, Whiteboard: [b2g-crash])
Crash Data
Attachments
(2 files)
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is
report bp-7d7db92b-23e3-41e1-aa90-d93532140402.
=============================================================
STR:
1. Enable cell data or WiFi
2. open cost Control and go through the FTU steps
3. tap the home button
expected:
3. We switch to homescreen app
Actual:
3. app crashes
Build ID:
Gaia 6274b3645b3d41df4aa5a55398b5d106edf1c528
Gecko https://hg.mozilla.org/mozilla-central/rev/4941a2ac0786
BuildID 20140402040201
Version 31.0a1
ro.build.version.incremental=324
ro.build.date=Thu Dec 19 14:04:55 CST 2013
We where able to reproduce this manually using the wifi connection
Reporter | ||
Comment 1•11 years ago
|
||
This might be affected by:
Bug 988979 - [B2G][General] After restarting or resetting device does not detect SIM card
Updated•11 years ago
|
Component: Gaia::Cost Control → Graphics
Product: Firefox OS → Core
Version: unspecified → Trunk
Updated•11 years ago
|
blocking-b2g: --- → 1.5?
Component: Graphics → Graphics: Layers
Whiteboard: [b2g-crash]
Comment 3•11 years ago
|
||
This also happens on Fennec Nightly when installing and running the Mozzle app <https://marketplace.firefox.com/app/mozzle>:
https://crash-stats.mozilla.com/report/index/deb7e5b6-c75e-45d7-a683-3b4dc2140402
Comment 4•11 years ago
|
||
I also get this crash signature every time I open http://outside.aalto.fi/ in Android Fennec Nightly
Comment 5•11 years ago
|
||
I also get this crash signature after installing "Penguin Pop" in Fennec Nightly 31.0a1 (2014-04-03) on LG Nexus 4 (Android 4.4.2).
Comment 6•11 years ago
|
||
Last good revision: 35180f110e44
First bad revision: 561b9329d832
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=35180f110e44&tochange=561b9329d832
Keywords: regressionwindow-wanted
Assignee | ||
Comment 9•11 years ago
|
||
As far as I can tell we never call SwapProducer when using SurfaceStream/canvas-2d/skia-gl and BasicLayers.
Accelerated layers get this called from CanvasClient/ClientCanvasLayer. WebGLContext does this in the PreTransactionCallback.
Should we do the same for canvas-2d?
Flags: needinfo?(matt.woodrow) → needinfo?(jgilbert)
Comment 11•11 years ago
|
||
Assignee | ||
Comment 12•11 years ago
|
||
A bit more information:
It appears we're crashing because mSurface in Basic/CopyableCanvasLayer is nullptr. We used to null check this value, and now we don't.
Looks like this crash only happens when we have skia-gl for canvas-2d so I believe the above is the underlying issue.
I'll put up a patch to put back the null check too.
Assignee | ||
Comment 13•11 years ago
|
||
The old Thebes code used to do this, probably safest to continue doing so.
Attachment #8402452 -
Flags: review?(roc)
Attachment #8402452 -
Flags: review?(roc) → review+
Assignee | ||
Comment 15•11 years ago
|
||
Whiteboard: [b2g-crash] → [b2g-crash] [leave-open]
Comment 17•11 years ago
|
||
Comment 18•11 years ago
|
||
I can at least confirm that the Android Nightly seems to not crash any more in places where it did on yesterday's Nightly with this signature. Thanks!
Comment 19•11 years ago
|
||
This is no longer reproducing with the patch in comment 17.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 20•11 years ago
|
||
(In reply to Matt Woodrow (:mattwoodrow) from comment #9)
> As far as I can tell we never call SwapProducer when using
> SurfaceStream/canvas-2d/skia-gl and BasicLayers.
>
> Accelerated layers get this called from CanvasClient/ClientCanvasLayer.
> WebGLContext does this in the PreTransactionCallback.
>
> Should we do the same for canvas-2d?
If you don't, the compositor won't get updates, so yes.
We should test this with a pref-changing reftest.
Flags: needinfo?(jgilbert)
Updated•11 years ago
|
Assignee: nobody → matt.woodrow
status-b2g-v2.0:
--- → fixed
status-firefox31:
--- → fixed
Whiteboard: [b2g-crash] [leave-open] → [b2g-crash]
Target Milestone: --- → mozilla31
Updated•11 years ago
|
blocking-b2g: 1.5? → 1.5+
Comment 21•11 years ago
|
||
I still see this issue on my Keon (1.5.0.0-prerelease 31.0a1 2014-04-14).
Do I need to reset the phone to see this issue gone?
Comment 22•11 years ago
|
||
I'm not able to reproduce this anymore on Nightly (2014-04-23) using Nexus 5 (Android 4.4.2).
You need to log in
before you can comment on or make changes to this bug.
Description
•