Closed
Bug 991069
Opened 11 years ago
Closed 11 years ago
Optimize MPostWriteBarrier OOL path to not save non-volatile regs
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
Instead of saving all live regs, we only have to save volatile live regs. It's a minor optimization but pretty straight-forward and x64 (especially Win64) has a bunch of extra non-volatile regs.
Attachment #8400643 -
Flags: review?(terrence)
|
Assignee | |
Comment 1•11 years ago
|
||
(In reply to Jan de Mooij [:jandem] from comment #0)
> x64 (especially
> Win64) has a bunch of extra non-volatile regs.
And ARM of course: r4-r14 and d8-d14 are non-volatile.
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8400643 [details] [diff] [review]
Patch
Review of attachment 8400643 [details] [diff] [review]:
-----------------------------------------------------------------
Nice! Every single cycle on this path is a win on Richards. r=me
Attachment #8400643 -
Flags: review?(terrence) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•