Closed
Bug 991271
Opened 11 years ago
Closed 7 years ago
After failing WrapNewBindingObject call we should be able to consistently check MOZ_ASSERT(JS_IsExceptionPending(cx));
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: smaug, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
Now that Gecko controls error reporting and the JS engine is no longer doing
JS_IsRunning checks, we should consistently have exceptions here.
MozReview-Commit-ID: IqBe5ArJc2l
Attachment #8908939 -
Flags: review?(continuation)
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
|
||
Updated•7 years ago
|
Attachment #8908939 -
Flags: review?(continuation) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/98f9bde465d2
Restore our assertions about how wrapping failure should mean an exception was thrown. r=mccr8
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•