Cork Reporter
	Description • 10 years ago

GTK3 builds crash if you inspect anything in the #tab-view-deck deck. GTK2 works without crashing. This has been tested with https://hg.mozilla.org/mozilla-central/rev/7bacc9e903b0

STR:
1. Create a clean profile
2. Install https://addons.mozilla.org/en-US/firefox/addon/dom-inspector-6622
3. start dom inspector from the web developer menu
4. select the main firefox window from file > Inspect Chrome Document
5. Use the element picker or focus window > deck (or any of the children under it

Result:

Program received signal SIGSEGV, Segmentation fault.
gfxContext::gfxContext (this=0x7fffc0dca840, surface=0x0) at /tmp/mozilla/mozilla-central/gfx/thebes/gfxContext.cpp:88
88	  mCairo = cairo_create(surface->CairoSurface());

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 1 • 10 years ago

Well, the question is whether (nsIWidget *)->GetThebesSurface() can return null or not.

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 2 • 10 years ago

Hm, it's because gfxASurface * nsWindow::GetThebesSurface() is not implemented in gtk3, we need some cairo context here to get the surface.

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 3 • 10 years ago

Katl, what do you think about this one? It implements nsWindow::GetThebesSurface() and returns actual mThebesSurface instead of just null.

	Cork Reporter
	Comment 4 • 10 years ago

Any progress on this?

The possibility to inspect the browser chrome is a blocker for me to use these builds.

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 5 • 10 years ago

Let's fix it as a part of Bug 1013552.

	Karl Tomlinson (:karlt)
	Comment 6 • 10 years ago

I guess nsIWidget::GetThebesSurface() was called from http://hg.mozilla.org/mozilla-central/annotate/9506880e4879/layout/inspector/inFlasher.cpp#l134