Closed Bug 991446 Opened 11 years ago Closed 11 years ago

Fix coverage when tests are run in their own sandbox

Categories

(Firefox OS Graveyard :: Gaia::TestAgent, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TestAgent
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: rickychien)

References

Details

Attachments

(4 files)

Gaia PR
(deleted), text/x-github-pull-request
yurenju
: review+
Details
Js-test-agent PR
(deleted), text/x-github-pull-request
yurenju
: review+
Details
Gaia-node-modules PR
(deleted), text/x-github-pull-request
yurenju
: review+
Details
Gaia PR - update node_modules revision
(deleted), text/x-github-pull-request
Details
Bug 864178 adds support for sandboxing of test files which is greatly needed to stop us from breaking TBPL. Unfortunately this has the side-effect of making the COVERAGE=1 flag not as nice because it gets reported for each and every file.
I'm going to fix this if I feel free
Assignee: nobody → ricky060709
Status: NEW → ASSIGNED
Attached file Gaia PR (deleted) —
Attachment #8408112 - Flags: review?(yurenju.mozilla)
Attached file Js-test-agent PR (deleted) —
Attachment #8408113 - Flags: review?(yurenju.mozilla)
Attached file Gaia-node-modules PR (deleted) —
Attachment #8408114 - Flags: review?(yurenju.mozilla)
Comment on attachment 8408113 [details] Js-test-agent PR discussed with Ricky offline and r=yurenju if issues mentioned on github are fixed.
Attachment #8408113 - Flags: review?(yurenju.mozilla) → review+
Attachment #8408112 - Flags: review?(yurenju.mozilla) → review+
Attachment #8408114 - Flags: review?(yurenju.mozilla) → review+
Landed a follow-up to include the latest revision in gaia_node_modules.revision which is now necessary: https://github.com/mozilla-b2g/gaia/commit/7e93b6de9633a162b735252e8182974456f741f4
Thanks Kevin :)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: