Closed
Bug 991468
Opened 11 years ago
Closed 10 years ago
CSP in C++: Remove isInitialized after we remove the old parser
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: ckerschb, Assigned: geekboy)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-needed)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
grobinson
:
review+
ckerschb
:
review+
|
Details | Diff | Splinter Review |
Once the new parser is landed, we can remove the
> attribute boolean isInitialized;
from nsIContentSecurityPolicy.idl because it's never queried.
|
Assignee | |
Updated•11 years ago
|
|
|
Assignee | |
Comment 1•10 years ago
|
||
proposed patch. The IDL change bumps the UUID, so will the IDL changes in bug 994872 and bug 991474. These are all little patches, so they could probably all land at the same time to avoid UUID churn.
Obviously, this requires bug 994782 to be fixed before we land this.
|
|
Assignee | |
Comment 2•10 years ago
|
||
Also, pushed this along with bug 994872, bug 994782 and bug 991474 to try to see how they do:
https://tbpl.mozilla.org/?tree=Try&rev=23c1af15cb65
Attachment #8431965 -
Attachment is obsolete: true
Attachment #8462910 -
Flags: review?(mozilla)
Attachment #8462910 -
Flags: review?(grobinson)
|
||
Updated•10 years ago
|
Attachment #8462910 -
Flags: review?(grobinson) → review+
|
Reporter | |
Comment 3•10 years ago
|
||
Comment on attachment 8462910 [details] [diff] [review]
remove-isInitialized
Review of attachment 8462910 [details] [diff] [review]:
-----------------------------------------------------------------
Looks great! Landing time.
Attachment #8462910 -
Flags: review?(mozilla) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
flagging dev-doc-needed since this is a change for the IDL. We should probably update the dev-docs for the other bugs that change the API and land the same time as this (see comment 2).
Keywords: dev-doc-needed
|
|
Assignee | |
Comment 5•10 years ago
|
||
Target Milestone: --- → mozilla34
|
||
Comment 6•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•