Closed
Bug 991555
Opened 11 years ago
Closed 11 years ago
Native prefs in the prefs screen are not written to shared prefs file
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox29 unaffected, firefox30 unaffected, firefox31 verified, fennec31+)
VERIFIED
FIXED
Firefox 31
| Tracking | Status | |
|---|---|---|
| firefox29 | --- | unaffected |
| firefox30 | --- | unaffected |
| firefox31 | --- | verified |
| fennec | 31+ | --- |
People
(Reporter: TeoVermesan, Assigned: bnicholson)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
Tested with:
Build: Firefox for Android 31.0a1 (2013-04-02)
Device: LG Nexus 4
OS: Android 4.4.2
From Settings -> Customize -> Tab choose "Always restore"
Steps to Reproduce:
1. Open some web pages in different tabs
2. Exit Firefox from app menu or from Task Manager
3. Start firefox
Expected result:
- Tabs loaded at Step 1 are restored
Actual Result:
- Tabs loaded at Step 1 are not restored.
|
||
Comment 1•11 years ago
|
||
The bug is also reproducible on HTC One X (Android 4.1.1)
|
Assignee | |
Comment 2•11 years ago
|
||
Most likely a regression from 940575 (per-profile prefs).
Blocks: 940575
Keywords: regression
|
||
Updated•11 years ago
|
tracking-fennec: --- → ?
|
||
Updated•11 years ago
|
Assignee: nobody → bnicholson
tracking-fennec: ? → 31+
|
|
Assignee | |
Comment 3•11 years ago
|
||
After choosing Always Restore, I found the pref gets saved to org.mozilla.fennec_brian_preferences.xml instead of GeckoApp.xml. Our prefs screen needs to be changed to use our custom shared prefs file.
Summary: Tabs are not restored with "Always restore" option enabled → Native prefs in the prefs screen are not written to shared prefs file
|
|
Assignee | |
Comment 4•11 years ago
|
||
At first, I tried calling `PreferenceManager.setDefaultValues(this, GeckoSharedPrefs.APP_PREFS_NAME, Context.MODE_PRIVATE, R.xml.preferences, false);` from GeckoPreferences, but this had no effect. Accessing the PreferenceManager directly and setting the name seems to do the trick.
Attachment #8401586 -
Flags: review?(rnewman)
|
|
Assignee | |
Comment 5•11 years ago
|
||
BTW, if we're using preference headers, getPreferenceManager() returns null when called from the PreferenceActivity (https://groups.google.com/forum/#!topic/android-developers/O88vw6rCRes). This is why I had to do the call in two different places.
|
||
Updated•11 years ago
|
Attachment #8401586 -
Flags: review?(rnewman) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
|
||
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
|
Reporter | |
Updated•11 years ago
|
|
|
Reporter | |
Comment 8•11 years ago
|
||
Verified fixed on:
Build: Firefox for Android 31.0a1 (2013-04-06)
Device: LG Nexus 4
OS: Android 4.4.2
Status: RESOLVED → VERIFIED
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•