Closed
Bug 991627
Opened 11 years ago
Closed 11 years ago
[Tarako] Remove Keyboard settings and dictionaries
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(blocking-b2g:1.3T+, b2g-v1.3T verified, b2g-v1.4 unaffected, b2g-v2.0 unaffected)
VERIFIED
FIXED
blocking-b2g | 1.3T+ |
Tracking | Status | |
---|---|---|
b2g-v1.3T | --- | verified |
b2g-v1.4 | --- | unaffected |
b2g-v2.0 | --- | unaffected |
People
(Reporter: rudyl, Assigned: rudyl)
Details
(Whiteboard: 1.3tarakorun1,[FT:System-Platform][tarako_only])
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #989268 +++
As an offline discussion with Marvin and Evelyn, need to remove keyboard dictionary and settings since those feature cannot work properly on Tarako and we want to prevent the user from enabling this functions.
--
1. Remove Keyboard settings in 1.3T
1.1 Click sound,
1.2 Auto correction
1.3 Word suggestion
2. Remove Keyboard dictionaries since they cannot be enabled and to save ROM size.
Assignee | ||
Comment 1•11 years ago
|
||
Marvin,
Need your help to confirm this requirement.
Thanks.
Flags: needinfo?(mkhoo)
Assignee | ||
Updated•11 years ago
|
Summary: [Tarako] Remove Keyboard settings configuration → [Tarako] Remove Keyboard settings and dictionaries
Comment 2•11 years ago
|
||
We got a few bugs reported that saying keyboard is not responsive (e.g. bug 990457), so rather than making these settings default off, I'd like to remove this feature from 1.3t.
Furthermore, if we do this, we got extra 1.4M memory gain, as well as reduce ROM size.
Comment 3•11 years ago
|
||
(In reply to Evelyn Hung [:evelyn] from comment #2)
> Furthermore, if we do this, we got extra 1.4M memory gain, as well as reduce
> ROM size.
it's because the en dictionary is 1.4M, and we load the whole file in run time if word suggestion/auto correction enabled.
https://github.com/mozilla-b2g/gaia/blob/v1.3t/keyboard/dictionaries/en.dict
Comment 4•11 years ago
|
||
over a separate email, Product/TAM confirms this is to be done. 1.3T+
blocking-b2g: 1.3T? → 1.3T+
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → rlu
Comment 5•11 years ago
|
||
Hi Rudy,
Yes, please remove Click sound, Auto correction and word suggestion including corresponding dictionaries.
Please make vibration as default on. Thanks!
Flags: needinfo?(mkhoo)
Assignee | ||
Comment 6•11 years ago
|
||
Tim,
Could you please help review this change?
Thank you.
Attachment #8401945 -
Flags: review?(timdream)
Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Comment 7•11 years ago
|
||
Comment on attachment 8401945 [details]
Patch V1 - pull request 17980
Please also remove the dictionary in the build to, either by making the build script skipping copying the dictionary, or actually delete the files (please make sure there isn't any error in build script if you remove the file).
Attachment #8401945 -
Flags: review?(timdream) → review+
Assignee | ||
Comment 8•11 years ago
|
||
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #7)
> Comment on attachment 8401945 [details]
> Patch V1 - pull request 17980
>
> Please also remove the dictionary in the build to, either by making the
> build script skipping copying the dictionary, or actually delete the files
Yes, the build script has been modified so that it won't copy the dictionaries.
> (please make sure there isn't any error in build script if you remove the
> file).
Landed to Gaia v1.3t,
https://github.com/mozilla-b2g/gaia/commit/9afe8145b5d309bdf2ef196b559e6dfd997faeeb
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-b2g-v1.3T:
--- → fixed
status-b2g-v1.4:
--- → unaffected
status-b2g-v2.0:
--- → unaffected
Resolution: --- → FIXED
Comment 9•11 years ago
|
||
Verified that Click sound, Auto Correction and Word Suggestion removed from keyboard settings in Settings on the latest 1.3T build. Also verified dictionaries do not populate when typing in a text field that provides dictionaries (MMS,Contacts, Email, Calendar)
Environmental Variables:
Device: Tarako 1.3T MOZ
BuildID: 20140429014002
Gaia: b5adc5a943d3abbd6ab070a47c847f2c24891cc5
Gecko: e9890f5d4709
Version: 28.1
Firmware Version: sp6821a_gonk4.0_user.pac
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•