Closed
Bug 991745
Opened 11 years ago
Closed 10 years ago
Change "Search HTML" placeholder text to indicate the search is by CSS Selectors only
Categories
(DevTools :: Inspector, defect)
DevTools
Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 38
People
(Reporter: bgrins, Assigned: gioyik, Mentored)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
As noted in https://bugzilla.mozilla.org/show_bug.cgi?id=835896#c19, the text for the placeholder for the search box in the markup view should be changed, since it isn't searching the HTML.
Maybe: "Search with CSS Selectors"?
Comment 1•10 years ago
|
||
Hi,
Can I be assigned this bug please?
Thanks
David
Reporter | ||
Comment 2•10 years ago
|
||
> Can I be assigned this bug please?
Sure, do you have a running Firefox build? If not, then first follow the instructions here: https://wiki.mozilla.org/DevTools/Hacking.
So basically the code changes needed for this bug are:
* Change the hardcoded string in place from "Search HTML" in inspectorSearchHTML.label here: http://dxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/devtools/inspector.dtd#21.
* Change the name from inspectorSearchHTML.label to inspectorSearchHTML.label2 (this allows localizers to see the change).
* Replace any references to the label entity to the label2 entity: http://dxr.mozilla.org/mozilla-central/search?q=inspectorSearchHTML.label&case=true&redirect=true.
* Test and make sure the string has been updated locally
Assignee: nobody → nelsond5
Mentor: bgrinstead
Reporter | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Comment 3•10 years ago
|
||
Hi Brian,
Yeah, I have a running Firefox build. I'll update thread if I have any questions.
Many thanks,
David
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8554090 -
Flags: review?(bgrinstead)
Assignee | ||
Comment 5•10 years ago
|
||
Hi Brian,
I attached a patch for this bug. Can you check it an let me know if it's ok?
Reporter | ||
Updated•10 years ago
|
Assignee: nelsond5 → gioyik
Reporter | ||
Comment 6•10 years ago
|
||
Comment on attachment 8554090 [details] [diff] [review]
991745.patch
Review of attachment 8554090 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good
Attachment #8554090 -
Flags: review?(bgrinstead) → review+
Reporter | ||
Comment 7•10 years ago
|
||
Keywords: checkin-needed
Comment 8•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Comment 9•10 years ago
|
||
Thank you
Comment 10•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
Comment 11•10 years ago
|
||
Great. But can someone explain how to search for (and find) Named Character Reference? Plain Text?
Background:
https://bugzilla.mozilla.org/show_bug.cgi?id=967493
https://bugzilla.mozilla.org/show_bug.cgi?id=835896
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•