Peter Dolanjski [:pdol] Reporter
	Description • 11 years ago

      No description provided.

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 1 • 11 years ago

On it from now on.

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 2 • 11 years ago

Rough idea now:
[Before transition] Rotate and translate the prev/next appWindow to the left side/right side of current window by its orientation settings
[During transition] Maintain a transformation matrix and its inverse matrix in the appWindow. Implement AppWindow.prototype.moveLeft/AppWindow.prototype.moveRight which uses the inverse matrix.
[After transition] Remove the transform of the appWindow and lock screen orientation at the same time.

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 3 • 11 years ago

The states machine for sheet transition:
### States ###
* Center
* Left
* Right
* CtL
* CtR
* RtC
* RtL

### Events ###
* move
* forward (success)
* back (cancel)

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 4 • 10 years ago

1. Have window_layout.css to store layout rules
2. Have placeholder in appWindow
3. Have sheetTransitionController mixin

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 5 • 10 years ago

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #4)
> Created attachment 8426931 [details]
> WIP
> 
> 1. Have window_layout.css to store layout rules
> 2. Have placeholder in appWindow
> 3. Have sheetTransitionController mixin

The function basically works but:
Need to clean sheet_transition.js
Need to fix some stack error in stack_manager
Need more tests.

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 6 • 10 years ago

Comment on attachment 8426931 [details]
WIP

* Move some logic which is appWindow specific from sheets_transition to sheet_transition_controller within AppWindow.
* Move some logic which is appWindow specific from stack_manager to sheet_transition_controller within AppWindow.
* Rewrite the layout logic of AppWindow: now all window are as same size as the device. The size of the iframe is changing with statusbar and something else.

Known issues
* Unwanted next window is appearing when sheet transitioning.
* Unsmooth transform.
* Fallen tests.
* App without orientation(browser app) will break current logic.

I will try to stabilize this patch tomorrow.

	Etienne Segonzac (:etienne) Assignee
	Comment 7 • 10 years ago

Comment on attachment 8426931 [details]
WIP

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #6)
> Comment on attachment 8426931 [details]
> WIP
> 
> * Move some logic which is appWindow specific from sheets_transition to
> sheet_transition_controller within AppWindow.
> * Move some logic which is appWindow specific from stack_manager to
> sheet_transition_controller within AppWindow.
> * Rewrite the layout logic of AppWindow: now all window are as same size as
> the device. The size of the iframe is changing with statusbar and something
> else.

(left some random comments on github)

The SheetTransition re-organisation with a SheetTransitionController and a SheetTransitionManager looks promising and it's going to be fun to test the getTransformString method :)

But I'm a bit worried about the removal of the broadcastTimeout logic in the StackManager.
How are we going to implement the feature (ie. being able to swipe past an app in a different orientation without stopping) if we're not queuing the swipes and broadcasting only 1 app change?

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 8 • 10 years ago

(In reply to Etienne Segonzac (:etienne) from comment #7)
> Comment on attachment 8426931 [details]
> WIP
> 
> (In reply to Alive Kuo [:alive][NEEDINFO!] from comment #6)
> > Comment on attachment 8426931 [details]
> > WIP
> > 
> > * Move some logic which is appWindow specific from sheets_transition to
> > sheet_transition_controller within AppWindow.
> > * Move some logic which is appWindow specific from stack_manager to
> > sheet_transition_controller within AppWindow.
> > * Rewrite the layout logic of AppWindow: now all window are as same size as
> > the device. The size of the iframe is changing with statusbar and something
> > else.
> 
> (left some random comments on github)
> 
> The SheetTransition re-organisation with a SheetTransitionController and a
> SheetTransitionManager looks promising and it's going to be fun to test the
> getTransformString method :)
> 
> But I'm a bit worried about the removal of the broadcastTimeout logic in the
> StackManager.
> How are we going to implement the feature (ie. being able to swipe past an
> app in a different orientation without stopping) if we're not queuing the
> swipes and broadcasting only 1 app change?

Ya, it's something I missed...
Thanks, I will think about this again and provide fix in next round.

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 9 • 10 years ago

Status today:
Added the delay commit timer back but the complex call route makes me sad. I will consider how to improve this section tomorrow.

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 10 • 10 years ago

Status today:
Rework edgeSwipeDetector and its test - all pass.

Next:
Add test for sheetTransitionManager and sheetTransitionController

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 11 • 10 years ago

Comment on attachment 8426931 [details]
WIP

WIP v2:
Still having some issues but need feedback on architecture change from v1.
* Adding window_layout.css
* Fix orientation-free app by getting rotationg degree from its width/height.
* Move "commit" from stackManager into appWindow.
* Fix some edgeSwipeDetector test issues

Todo
* Keyboard issues seems reoccured.
* Window opacity conflicts
* Sometimes the center sheet returns to center area during swipe.
* Statusbar is annoying during sheet transition

	Etienne Segonzac (:etienne) Assignee
	Comment 12 • 10 years ago

Comment on attachment 8426931 [details]
WIP

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #11)
> Comment on attachment 8426931 [details]
> WIP
> 
> WIP v2:
> Still having some issues but need feedback on architecture change from v1.
> * Adding window_layout.css

+1

> * Fix orientation-free app by getting rotationg degree from its width/height.

+1 

> * Move "commit" from stackManager into appWindow.

Mmmhh, AppWindowManager maybe, but the "commiting concept" isn't at the window level but one level above.

> Todo
> * Keyboard issues seems reoccured.
> * Window opacity conflicts
> * Sometimes the center sheet returns to center area during swipe.
> * Statusbar is annoying during sheet transition

There are a lot of refactoring (and other bugs) being addressed in this patch, I'm supportive of pretty much all of them. But I don't think we can get this rewrite landed by tomorrow without regressions.
I'm especially worried about performance regressions that I can already see in this WIP.

I think we should move forward with the approach here, but I'm also preparing a simpler patch for this user story for the 2.0 timeframe.
I have a ~25 lines patch that fits the user story acceptance criteria, going to attach it for feedback.

	Etienne Segonzac (:etienne) Assignee
	Comment 13 • 10 years ago

This is a small patch focusing on the user story described here.
We can show it to the UX team in an hour for feedback. If it's accepted I'm pretty sure we can get it landed tomorrow.

What do you think?

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 14 • 10 years ago

Comment on attachment 8434672 [details]
POC - without tests for now

Nice one.

	Etienne Segonzac (:etienne) Assignee
	Comment 15 • 10 years ago

Here we go, now with tests!

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 16 • 10 years ago

Comment on attachment 8434775 [details]
Gaia PR

Quick and good patch. Thank you Etienne.

	Etienne Segonzac (:etienne) Assignee
	Comment 17 • 10 years ago

https://github.com/mozilla-b2g/gaia/commit/cd1550ddfb3b95e1a06037f98779d6eb2423b6a8

	Kevin Grandon :kgrandon
	Comment 19 • 10 years ago

Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.