Closed Bug 992129 Opened 11 years ago Closed 11 years ago

[DSDS] Voicemail notification tag does not handle properly multiple SIMs

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:1.4+, b2g-v1.4 fixed, b2g-v2.0 fixed)

Status:
VERIFIED FIXED
Milestone:
1.4 S5 (11apr)
Project Flags:
blocking-b2g 1.4+
Tracking Flags:
Tracking Status
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

Link to Github https://github.com/mozilla-b2g/gaia/pull/17986
(deleted), text/x-github-pull-request
etienne
: review+
Details
The current voicemail notification tag does not take into account the SIM/voicemail number it is adding a notification for. STR: 0. Receive voicemail on SIM1 1. Receive voicemail on SIM2 Expected: We have two notifications Actual: Only once notification is shown I already have a patch that should be okay, need to add testing.
Whiteboard: [systemsfe]
Depends on: 980701
blocking-b2g: 1.3? → 1.4?
Pleade find attached a link to the github pull request that fixes the issue.
Attachment #8401894 - Flags: review?(timdream)
Attachment #8401894 - Flags: review?(timdream) → review?(etienne)
Comment on attachment 8401894 [details] Link to Github https://github.com/mozilla-b2g/gaia/pull/17986 Comments on github, let me know if anything is unclear.
Attachment #8401894 - Flags: review?(etienne)
Fixed a couple of things, and I could test at least on a single SIM device, without any issue.
Comment on attachment 8401894 [details] Link to Github https://github.com/mozilla-b2g/gaia/pull/17986 (In reply to Alexandre LISSY :gerard-majax from comment #4) > Fixed a couple of things, and I could test at least on a single SIM device, > without any issue. Please flag me for review again when it's the case, otherwise I might miss it. Will have a look this morning!
Attachment #8401894 - Flags: review?(etienne)
(In reply to Alexandre LISSY :gerard-majax from comment #4) > Fixed a couple of things, and I could test at least on a single SIM device, > without any issue. Of course, but after our discussion yesterday, I was waiting to do a real test on a real device, just to be sure.
Comment on attachment 8401894 [details] Link to Github https://github.com/mozilla-b2g/gaia/pull/17986 r=me wit the nits addressed (on github)
Attachment #8401894 - Flags: review?(etienne) → review+
(In reply to Etienne Segonzac (:etienne) from comment #7) > Comment on attachment 8401894 [details] > Link to Github https://github.com/mozilla-b2g/gaia/pull/17986 > > r=me wit the nits addressed (on github) Thanks. I've addresses the nits, travis is green, but I'm sad, I'm unable to get my hands on a device that we can make work with DSDS and running master.
blocking-b2g: 1.4? → 1.4+
https://github.com/mozilla-b2g/gaia/commit/8f158a66eb18071f470ac95f923c75fa8e2edc4a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Okay on Fugu v1.4 GAIA_REV=8dff633372022723e2ebad17fe3c826436b3b258 GECKO_REV=574e5ded8f4cd4f4177bbbbfea408e04ae66dddd GAIA_BRANCH=mozillaorg/v1.4 GECKO_BRANCH=mozillaorg/v1.4 BUILD_TAG=jenkins-B2G.v1.4.0.fugu-23 BuildID=20140414041552
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: