Closed Bug 99247 Opened 23 years ago Closed 12 years ago

remove use of strtok

Categories

(Core Graveyard :: Profile: BackEnd, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME
Future

People

(Reporter: drepper, Unassigned)

Details

Attachments

(1 file)

(I hope profile/src/nsProfile.cpp is in the frontend, otherwise please reassign.) This file is still using strtok which is an evil since not thread-safe function. I'll shortly attach a patch which makes the code use nsCRT::strtok which is a safe replacement.
Keywords: patch, review
it looks ok to me,...
Assignee: ben → ccarlen
Component: Profile Manager FrontEnd → Profile Manager BackEnd
It's not really an issue here because the place in which strtok is used always happens on the main thread and before there are any other threads.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0
Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 (you can query for this string to delete spam or retrieve the list of bugs I've moved)
Target Milestone: mozilla1.0 → mozilla1.0.1
Assignee: ccarlen → nobody
Status: ASSIGNED → NEW
Target Milestone: mozilla1.0.1 → Future
Filter on "Nobody_NScomTLD_20080620"
QA Contact: ktrina → profile-manager-backend
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WORKSFORME
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: