Closed Bug 992929 Opened 11 years ago Closed 10 years ago

[FindMyDevice] The URL in find my device page under setting is incorrect

Categories

(Firefox OS Graveyard :: FindMyDevice, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:2.0+, b2g-v2.0 verified, b2g-v2.1 verified)

VERIFIED FIXED
2.0 S5 (4july)
blocking-b2g 2.0+
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- verified

People

(Reporter: njpark, Assigned: kglazko)

References

Details

Attachments

(4 files)

STR: Go to Settings, and select Find My Device If not logged into FxAccount yet, log in by supplying email and password. After login, enable find my device option. Expected: Under 'About Find My Device' it lists findmydevice.mozilla.com Actual: It shows FindMyDevice.com, which actually upon clicking, takes the user to findmydevice.mozilla.com. Going to FindMyDevice.com on a PC takes the users to a non-operational non-mozilla site.
Happy to fix. Can I see a screenshot?
Flags: needinfo?(npark)
Attached image 2014-04-08-19-11-52.png (deleted) —
Here's the screenshot. The proper url is findmydevice.mozilla.com i think.
Flags: needinfo?(npark)
Oh, so this is definitely not our bug, this is for the find my device folks. Changing the component.
Component: FxA → WMF
the agreed upon URL is find.firefox.com the decision is tracked in 1017747
Assignee: nobody → kglazko
Depends on: 941258
blocking-b2g: --- → 2.0?
Target Milestone: --- → 2.0 S4 (20june)
No longer depends on: 941258
Depends on: 941258
We need to have the right URL on the phone before shipping, so blocking here.
blocking-b2g: 2.0? → 2.0+
Attached file Pull Request for Bug 992929 (deleted) —
Attachment #8441731 - Flags: review?(ggoncalves)
Comment on attachment 8441731 [details] Pull Request for Bug 992929 Thanks! r+, but with two comments: Should we be using https:// in the link? I believe we should, but :jrconlin will know for sure. Also (and this is admittedly a very minor thing), can you please update the commit message so it explains the fix, instead of redescribing the bug? That's the preferred format [1]. Something like "Bug 992929 - Update Find My Device's URL in the Settings app" would be good. 1- https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Committing_Rules_and_Responsibilities#Checkin_comment
Attachment #8441731 - Flags: review?(ggoncalves) → review+
I git amended my commit to read the description above ^.
Ok, committed https:// and squashed.
Keywords: checkin-needed
Unsetting checkin-needed, this needs an r+ *from a settings owner or peer* to be merged.
Keywords: checkin-needed
Target Milestone: 2.0 S4 (20june) → 2.0 S5 (4july)
Comment on attachment 8441731 [details] Pull Request for Bug 992929 Hi Arthur, This is a little one-liner for find my device, and it's a 2.0 blocker. Would you mind reviewing? Thanks! Jared
Attachment #8441731 - Flags: review?(arthur.chen)
I couldn't link to "https://find.firefox.com" neither from my phone or my PC. Is the url correct?
Flags: needinfo?(6a68)
It's not an active link yet, we're just replacing the placeholder URL with what will be the actual URL.
Hi Arthur, Very reasonable question :-) find.firefox.com is the final URL, per this comment from the fmd PM: https://bugzilla.mozilla.org/show_bug.cgi?id=1017747#c14 Thanks! Jared
Flags: needinfo?(6a68)
Comment on attachment 8441731 [details] Pull Request for Bug 992929 r=me, thanks!
Attachment #8441731 - Flags: review?(arthur.chen) → review+
Well, the tests look good[1], but there's one last thing to do. Kate, can you add "r=arthurcc" at the end of the commit message? The simplest way is to do the following: 1. git checkout the branch for this bug 2. git commit --amend 3. when the editor opens, add " r=arthurcc" at the end 4. force push to the remote branch 5. set the checkin-needed keyword and the sheriffs will merge it (or ask me and i can merge it) Does this sound good? Grab me if you have any questions [1] https://travis-ci.org/mozilla-b2g/gaia/builds/28064949
Flags: needinfo?(kglazko)
Ah, looks like this needs to be rebased against master, too.
We got the rebasing sorted; clearing ni.
Flags: needinfo?(kglazko)
Issue no longer repros, find.firefox.com is now the displayed url in FMD settings. Environmental Variables: Device: Flame 2.0 Build ID: 20140630000201 Gaia: c0c8ad187c0466285f2580531e09f8322996f561 Gecko: d4dc609bcc8a Version: 32.0a2 (2.0) Firmware Version: v122 User Agent: Mozilla/5.0 (Mobile; rv:32.0) GEcko/32.0 Firefox/32.0
Status: RESOLVED → VERIFIED
Hi Hubert, This issue has been verified on Flame 2.1.But it displays message "Rumor has it that you can't find your device.Don't worry,we're the app for that.Sign in" after tapping the url "find.firefox.com".Please confirm this,thanks. See attachment: verify_v2.1.MP4 and logcat_1637.txt. STR: 1.Go to Settings and select Find My Device 2.Log in FxAccount. 3.After login, enable find my device option. 4.Tap the url. [Actual result]: 4.It displays message "Rumor has it that you can't find your device.Don't worry,we're the app for that.Sign in".And then tap "Sign in",it will go to sign in screen. Flame 2.1 build: Gaia-Rev db2e84860f5a7cc334464618c6ea9e92ff82e9dd Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/211eae88f119 Build-ID 20141126001202 Version 34.0 Device-Name flame FW-Release 4.4.2 FW-Incremental eng.cltbld.20141126.033519 FW-Date Wed Nov 26 03:35:30 EST 2014 Bootloader L1TC00011880
Flags: needinfo?(hlu)
Attached file logcat_1637.txt (deleted) —
Attached video verify_v2.1.MP4 (deleted) —
Flags: needinfo?(hlu)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: