Closed
Bug 993193
Opened 10 years ago
Closed 6 years ago
Move runtime localization logic post document loading for pretranslation case
Categories
(Firefox OS Graveyard :: Gaia::L10n, defect, P4)
Firefox OS Graveyard
Gaia::L10n
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: zbraniecki, Assigned: zbraniecki)
References
(Depends on 1 open bug)
Details
Attachments
(2 files)
(deleted),
patch
|
stas
:
review+
|
Details | Diff | Splinter Review |
(deleted),
text/x-github-pull-request
|
Details |
If the document is pretranslated, we currently fire l10n.js runtime logic on 'interactive'. Based on our tests we can improve startup performance by postponing it until 'complete'. There's one bug - bug 993189 - that currently relies on inconsistent behavior of ready() function (bug 993188).
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → gandalf
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8404191 -
Flags: review?(stas)
Comment 2•10 years ago
|
||
Comment on attachment 8404191 [details] [diff] [review] patch Review of attachment 8404191 [details] [diff] [review]: ----------------------------------------------------------------- r=me, but let's make sure we fix the dependencies first, before landing this.
Attachment #8404191 -
Flags: review?(stas) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•10 years ago
|
||
seems like we fail two marionette tests: https://travis-ci.org/mozilla-b2g/gaia/jobs/23162502
Assignee | ||
Comment 5•10 years ago
|
||
now only one test fails (in net_error!) https://travis-ci.org/mozilla-b2g/gaia/jobs/23312692
Assignee | ||
Comment 6•10 years ago
|
||
I just measured the gain we currently get from pretranslation on master, Keon: delta median ======================== browser -15 calendar 2 camera -37 clock 57 contacts 19 email 10 messages 65 music 24 phone 19 settings 109 usage 15 ======= AVG: 23
Assignee | ||
Comment 7•10 years ago
|
||
Erm, sorry, the numbers are reversed. In Comment 6 the delta is from pretranslate to non-pretranslate. It means that browser firstPaints 15 ms earlier in non-pretranslate case. Settings on the other hand firstPaint 109ms later in non-pretranslate case.
Comment 8•10 years ago
|
||
Are we still failing the tests? If I read the code right we already special-case the neterror page, so we should be good?
Comment 9•6 years ago
|
||
Firefox OS is not being worked on
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•