Closed
Bug 993197
Opened 10 years ago
Closed 10 years ago
Asynchronize nsILoginManager::autoCompleteSearch
Categories
(Toolkit :: Password Manager, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
Tracking | Status | |
---|---|---|
e10s | + | --- |
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
For bug 949617, we need to be able to asynchronously fill in logins for nsLoginManager-managed login fields. Currently, the code expects that to be a synchronous action, which is less than ideal.
Assignee | ||
Comment 1•10 years ago
|
||
One thing that I know I'm not doing is calling StopAutoCompleteSearch on the login manager when we call nsFormFillController::StopSearch. Is that important? https://tbpl.mozilla.org/?tree=Try&rev=4df854c3e162
Attachment #8403025 -
Flags: review?(dolske)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → mrbkap
Comment 2•10 years ago
|
||
Mass tracking-e10s flag change. Filter bugmail on "2be0fcce-e36a-4e2c-aa80-0e3d33eb5406".
tracking-e10s:
--- → +
Comment 4•10 years ago
|
||
Comment on attachment 8403025 [details] [diff] [review] Patch v1 Review of attachment 8403025 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/passwordmgr/nsLoginManager.js @@ +13,5 @@ > > XPCOMUtils.defineLazyModuleGetter(this, > "LoginManagerContent", "resource://gre/modules/LoginManagerContent.jsm"); > > +var debug = true; I think you forgot to remove this. @@ +465,5 @@ > + // filter logins without a username, since that's confusing to see > + // in the dropdown and we can't autocomplete them anyway. > + for (let i = 0; i < logins.length; i++) { > + var username = logins[i].username.toLowerCase(); > + log(username); I think you forgot to remove this too.
Attachment #8403025 -
Flags: review?(dolske) → review+
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/654c1f0c88bc
Comment 6•10 years ago
|
||
Something in this push made Android sadface. Backed out. https://hg.mozilla.org/integration/mozilla-inbound/rev/6f291b1b47c7 https://tbpl.mozilla.org/php/getParsedLog.php?id=42378026&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=42378331&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=42377296&tree=Mozilla-Inbound
Assignee | ||
Comment 7•10 years ago
|
||
Take 2: https://hg.mozilla.org/integration/mozilla-inbound/rev/f556e62f5ee8
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f556e62f5ee8
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Comment 9•10 years ago
|
||
sorry had to back this out from mozilla-central in https://tbpl.mozilla.org/?onlyunstarred=1&rev=83f9b25520bf since one of this checkins seems to have caused Bug 1030663 which is a frequent test failurew now
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 10•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc701f3d06b2
Comment 11•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fc701f3d06b2
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•