When reading a long email, the bottom line gets covered by the toolbar. See attachment. Repro: 1) install 1.4 nightly on Buri device Gaia 86de7fcce674ef6196d68e7e23552d219a3d72db Gecko https://hg.mozilla.org/releases/mozilla-aurora/rev/6e028297be14 BuildID 20140407000203 Version 30.0a2 ro.build.version.incremental=eng.tclxa.20131223.163538 2) receive a long email in your inbox 3) scroll the email until the end, and verify the bottom line is covered by the toolbar. Expected; - all of the email text is shown. (ie. This is a long email.) Actual: - toolbar clipped. ("a long email")

qanalysts ,can you guys help find a regression range for this bug? it's certainly on 1.4, but want to know if this affects 1.3 or 1.5. Thanks!

The issue reproduces on the latest master, does not reproduce on 1.3 1.5 - repro BuildID: 20140408040204 Gaia: 1958454595b1fa0e061f0652ae965629993f5708 Gecko: 8883360b1edb Version: 31.0a1 1.3 - no repro BuildID: 20140408004002 Gaia: 0a7a50129995f080c1df4d807a2334701701e8ed Gecko: e3fca8c23e1d Version: 28.0

This issue started reproducing on the 01/10/14 Master (1.4) build. The UI changed between the 01/09 and 01/10 builds which seems to be part, if not all, of the problem. - Last Working - Device: Buri Master (1.4) MOZ RIL BuildID: 20140109040203 Gaia: 47206ac66b084c6f6c4503a3b10d0e0760df2b6f Gecko: 9409405e0739 Version: 29.0a1 Firmware Version: v1.2-device.cfg - First Broken - Device: Buri Master (1.4) MOZ RIL BuildID: 20140110040206 Gaia: f400efc804366c7b7cf5476d1d5d325e6651ee71 Gecko: 37516445a0b5 Version: 29.0a1 Firmware Version: v1.2-device.cfg **This looks to be a gaia issue.** last working gaia/first broken gecko = NO REPRO Gaia: 47206ac66b084c6f6c4503a3b10d0e0760df2b6f Gecko: 37516445a0b5 first broken gaia/last working gecko = REPRO Gaia: f400efc804366c7b7cf5476d1d5d325e6651ee71 Gecko: 9409405e0739 Push log: https://github.com/mozilla-b2g/gaia/compare/47206ac66b084c6f6c4503a3b10d0e0760df2b6f...f400efc804366c7b7cf5476d1d5d325e6651ee71

Caused by bug 947095.

Now that the toolbar is opaque, should we just change the scrolling region to not include the toolbar? There's not a lot of advantage to having an opaque thing overlay something else. The notable difference is that it does affect the vertical space the scroll-thumb lives in. If content can go under the toolbar, the scroll-thumb can go over the toolbar too.

That makes sense, assuming we're going to keep the opaque footer.

Comment on attachment 8406275 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18296 Canceling review until I reimplement per :asuth's suggestion.

Comment on attachment 8406275 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18296 Re-flagging for review; this version just modifies the scrollregion height to exclude precisely the area of the header and footer.

Hi, James, are you available to review? Thanks.

Comment on attachment 8406275 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18296 Left feedback in pull request. Flip review back to me when addressed, should be easy to r+ after that.

Comment on attachment 8406275 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18296 Updated the PR per your comments.

Comment on attachment 8406275 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18296 r+ from me, if the .card-message-reader style is moved to message_cards.css, near the other style in that file that starts with `.card-message-reader`, so that we can better manage the message card related styles together.

Hey guys, this one will be fixed in bug 992994, can I mark this as duplicate?

(In reply to Pavel Ivanov [:ivanovpavel] from comment #15) > Hey guys, > this one will be fixed in bug 992994, can I mark this as duplicate? No, this bug needs to uplifted to v1.4 so it should land on master before bug 992994 does. I was mentioning this bug on that bug for my own clarity and that of other reviewers since any place we have a calc() in our styling relating to visible/scroll areas there's a real risk for non-obvious regressions so we need to be very careful.

Moved the offending style to message_cards.css as you requested, and landed on master: https://github.com/mozilla-b2g/gaia/commit/28935fe853e914b90b9e59a0b883cb6c845f3da4

v1.4: https://github.com/mozilla-b2g/gaia/commit/fc95009476fac9ce205a59b237d146ca7f6f42e7