Closed Bug 993373 Opened 11 years ago Closed 11 years ago

The shade of blue is the same when an item is hovered and when it is selected on dropdowns for in-content preferences

Categories

(Firefox :: Settings UI, defect)

Product:
Firefox
Component:
Settings UI
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 32
Tracking Flags:
Tracking Status
firefox29 --- wontfix
firefox30 --- affected
firefox31 --- affected
firefox32 --- verified

People

(Reporter: cbadau, Assigned: vtsatskin)

References

Details

(Whiteboard: p=0 s=it-32c-31a-30b.2 [qa!])

Attachments

(1 file, 1 obsolete file)

Patch (r+d by jaws)
(deleted), patch
jaws
: review+
Details | Diff | Splinter Review
Reproducible on the latest Beta (BuildID: 20140407135746) Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20130205 Firefox/29.0 Reproducible on the latest Aurora (BuildID: 20140407004002) Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20130205 Firefox/30.0 Reproducible on the latest Nightly (BuildID: 20140407030203) Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0 Steps to reproduce: 1. Open about:preferences. 2. Observe the shade of blue when an item is hovered and when it is selected on dropdowns. Expected results: There are two different shades of blue : a lighter one for the hover state and a darker one for the click state. Actual results: There is the same shade of blue, for both when an item is hovered or selected. Notes: 1.This is reproducible also on Ubuntu x86 and on Mac OSX 10.9. 2.This issue is not a regression.
Blocks: 718011
Blocks: 738796
Assignee: nobody → vtsatskin
Attached patch 993373.patch (obsolete) (deleted) — — Splinter Review
Updated as per spec defined in bug 738796
Attachment #8406532 - Flags: review?(jaws)
Status: NEW → ASSIGNED
Flags: firefox-backlog?
Flags: firefox-backlog? → firefox-backlog+
Comment on attachment 8406532 [details] [diff] [review] 993373.patch Review of attachment 8406532 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/themes/shared/incontentprefs/preferences.css @@ +271,5 @@ > menulist > menupopup > menu[_moz-menuactive="true"], > menulist > menupopup > menuitem[_moz-menuactive="true"], > button[type="menu"] > menupopup > menu[_moz-menuactive="true"], > button[type="menu"] > menupopup > menuitem[_moz-menuactive="true"] { > + background-image: linear-gradient(#D1EBFF, #C5E3F9); Please use the values specified in the spec: background-image: linear-gradient(rgba(76,177,255,0.25), rgba(23,146,229,0.25)); Also, duplicate the above color to here so that the background-image and color are closely related. @@ +282,5 @@ > color: #FFFFFF; > background-image: linear-gradient(#4CB1FF, #1792E5); > } > > + This extra line isn't needed here.
Attachment #8406532 - Flags: review?(jaws) → feedback+
Attached patch Patch (r+d by jaws) (deleted) — — Splinter Review
Valentin, I've updated the patch to address my earlier feedback. This is now ready for check-in. Thanks!
Attachment #8406532 - Attachment is obsolete: true
Attachment #8419688 - Flags: review+
Hi Valentin, could you provide a Try link. Suggestions for what to run if you haven't yet can be found here: https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/adbdb1a417e2
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
Hi Juan, can you review this bug if it will require further QA verification.
Flags: needinfo?(jbecerra)
Whiteboard: p=0 s=it-32c-31a-30b.2 [qa?]
Whiteboard: p=0 s=it-32c-31a-30b.2 [qa?] → p=0 s=it-32c-31a-30b.1 [qa?]
Flags: needinfo?(jbecerra)
Whiteboard: p=0 s=it-32c-31a-30b.1 [qa?] → p=0 s=it-32c-31a-30b.1 [qa+]
Whiteboard: p=0 s=it-32c-31a-30b.1 [qa+] → p=0 s=it-32c-31a-30b.2 [qa+]
QA Contact: camelia.badau
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.8.5 using latest Nightly 32.0a1 (buildID: 20140512030202).
Status: RESOLVED → VERIFIED
status-firefox32: --- → verified
Whiteboard: p=0 s=it-32c-31a-30b.2 [qa+] → p=0 s=it-32c-31a-30b.2 [qa!]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: