Peter Van der Beken [:peterv] Assignee
	Description • 10 years ago

      No description provided.

	Boris Zbarsky [:bzbarsky]
	Comment 1 • 10 years ago

Comment on attachment 8403589 [details] [diff] [review]
v1

>+nsWindowSH::NameStructEnabled(JSContext* aCx, nsGlobalWindow *aWin,
>+                               const nsAString& aName,
>+                               const nsGlobalNameStruct& aNameStruct)

Fix indent?

>+    if (NS_FAILED(rv) || !nameStruct) {
>+      return true;

return false?

>+  if (aNameStruct.mType == nsGlobalNameStruct::eTypeStaticNameSet) {

Er, that's dead code.  I forgot to remove it when I removed the resolve bits that looked at that struct type...  Followup ok to nix this and the bits in the namespace manager that handle it, or you could do it here.

>+  // "Components" is marked as enumerable but only resolved on demand :-/.

Can we file a followup on fixing that one way or another?

>+++ b/dom/webidl/Window.webidl

The change here looks unrelated, but ok.

r=me

	Peter Van der Beken [:peterv] Assignee
	Comment 3 • 10 years ago

> Er, that's dead code.  I forgot to remove it when I removed the resolve bits
> that looked at that struct type...  Followup ok to nix this and the bits in
> the namespace manager that handle it, or you could do it here.

Why is that dead code? We have at least one of these in the tree.

	Boris Zbarsky [:bzbarsky]
	Comment 4 • 10 years ago

Oh, I was thinking of dynamic-nameset.

The static one is the fake PrivilegeManager.  We should find a better way to do that.

	Peter Van der Beken [:peterv] Assignee
	Comment 5 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/0ad53ad7c808

Still need to file the Components bug.

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/0ad53ad7c808