Vicamo Yang [:vicamo][:vyang] Assignee
	Description • 11 years ago

+++ This bug was initially created as a clone of Bug #979134 +++

Let's reuse http://dxr.mozilla.org/mozilla-central/source/dom/mobilemessage/tests/marionette/head.js whenever possible.

	Ken Chang[:kenkai]
	Comment 1 • 11 years ago

Put this bug into backlog.

	Vicamo Yang [:vicamo][:vyang] Assignee
	Comment 2 • 10 years ago

1) Fix:
* test_emulator_loopback.js
* test_filter_date.js
* test_getmessage.js
* test_getmessage_notfound.js
* test_getmessages.js
* test_incoming.js
* test_outgoing.js
2) merge test_filter_date_notfound.js into test_filter_date.js
3) merge test_incoming_multipart.js into test_incoming.js

Not _all_ SMS test cases are converted, just some done works so far.

	Gene Lian (I already quit Mozilla)
	Comment 3 • 10 years ago

Comment on attachment 8444301 [details] [diff] [review]
patch

Review of attachment 8444301 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mobilemessage/tests/marionette/test_getmessage_notfound.js
@@ +17,5 @@
> +      let error = aEvent.target.error;
> +      ok(error, "DOMError");
> +      is(error.name, "NotFoundError", "error.name");
> +    });
> +}  

nit: trailing spaces.

	Vicamo Yang [:vicamo][:vyang] Assignee
	Comment 4 • 10 years ago

Address previous nit only.

	Vicamo Yang [:vicamo][:vyang] Assignee
	Comment 5 • 10 years ago

Document pushPrefEnv() only.

	Vicamo Yang [:vicamo][:vyang] Assignee
	Comment 6 • 10 years ago

https://hg.mozilla.org/integration/b2g-inbound/rev/be39010d4f5e

	Carsten Book [:Tomcat]
	Comment 7 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/be39010d4f5e