Closed
Bug 99402
Opened 23 years ago
Closed 22 years ago
Pref dialog size should go en-win/mac/unix.jar
Categories
(Core :: Internationalization: Localization, defect)
Core
Internationalization: Localization
Tracking
()
VERIFIED
FIXED
Future
People
(Reporter: yinglinxia, Assigned: yinglinxia)
References
Details
(Keywords: intl)
Attachments
(1 file)
(deleted),
patch
|
nhottanscp
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
Currently the pref dialog size defined in locale\en-US\communicator\pref\pref.dtd, however, for different platforms, the size could be little different, especially for Asian languages.
Comment 1•23 years ago
|
||
->l10n?
Assignee: sgehani → rchen
Component: Preferences → Localization
QA Contact: sairuh → andreasb
Assignee | ||
Comment 2•23 years ago
|
||
Well, currently we have some different adjustment on different platforms for Japanese, but basically saying, this issue should not be l10n. For English, our current method is defining one size for all platforms, and I think it is not very right.
Reassigned to ben to move the following entity to a platform dependent file like "plaatformPrefOverlay". Because the layout apparently displays a little bit differently in different platforms. <!ENTITY prefWindow.size "width: 52em; height: 41em;">
Assignee: rchen → ben
Updated•23 years ago
|
Updated•23 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → Future
Comment 4•22 years ago
|
||
rchen and xyia what is the size for different platform and languages? what are the value for ja win ja mac ja linux de win de mac de linux zh-ch win fr win fr mac fr linux sp win sp mac sp linux pt win pt mac pt linux ?
Assignee | ||
Comment 5•22 years ago
|
||
For JA, in 0.9.4, win32: width: 62em; height: 44em; mac: width: 64em; height: 44em; But this is something we don't really need to care in the US build. And it may change depends on the translation string length. As long as the pref dialog seperated in the en-win/mac/unix.jar, it will be very easy for us to change the size for different languages on different platforms, and track the change with our translation memory tool.
![]() |
||
Comment 6•22 years ago
|
||
Mozilla German uses width: 58em; height:45em; for all platforms currently (en-US has width: 52em; height: 41em; btw)
Updated•22 years ago
|
Comment 8•22 years ago
|
||
Is any work being done on this? Can we get it into Moz 1.2? Let me know, if you want me to own this...
Comment 9•22 years ago
|
||
reassigning to jbetak.
Assignee: ben → jbetak
Status: ASSIGNED → NEW
Whiteboard: [adt3]
Assignee | ||
Comment 10•22 years ago
|
||
I have made some test with my patch on Windows and Mac, looks working fine.
Comment 11•22 years ago
|
||
but does it fit in 640x480 with space for a menubar/taskbar and a bit of margins so that it doesn't look like it's a fullscreen window?
Assignee: jbetak → yxia
Assignee | ||
Comment 12•22 years ago
|
||
This bug and the patch does not want to change the Pref dialog size, it's just make the size deinition more flexible for different languages on different platforms. For example, in the Japanese localization, we had to re-pack the ja-JP.jar for Mac and Unix differently, by modifying the pref.dtd with different size value. With this fix, we will be able to use same ja-JP.jar for all platforms, and just using different size value in ja-win.jar, ja-mac.jar and ja-unix.jar, to make the Pref dialog fit better on different platforms. This change actually can even avoid a global big Pref dialog.
Assignee | ||
Comment 13•22 years ago
|
||
Naoki-sensei, can you please review the patch? This bug fix can save lots of time for l10n. Thanks.
Comment 14•22 years ago
|
||
Comment on attachment 110905 [details] [diff] [review] a patch to make the Pref size platform-depended r=nhotta please fix pref.dtd for "\ No newline at end of file"
Attachment #110905 -
Flags: review+
Assignee | ||
Comment 15•22 years ago
|
||
Comment on attachment 110905 [details] [diff] [review] a patch to make the Pref size platform-depended Double-checked my new file, it's ok. Guess the "no newline" is because the original file does not contain newline.
Attachment #110905 -
Attachment description: a patch to fix make the Pref size platform-depended → a patch to make the Pref size platform-depended
Attachment #110905 -
Flags: superreview?
Comment 16•22 years ago
|
||
Comment on attachment 110905 [details] [diff] [review] a patch to make the Pref size platform-depended sr=jag
Attachment #110905 -
Flags: superreview? → superreview+
Assignee | ||
Comment 17•22 years ago
|
||
Checked in to trunk, thank Naoki for the help. Kasumi, I will test it tomorrow, and then you can verify it later -- should you still own this kind of bugs qa, btw?
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 18•22 years ago
|
||
Tested on today's Win32, Mac and Linux build, looks working good. Kasumi, can you please verify it now. Thanks.
You need to log in
before you can comment on or make changes to this bug.
Description
•