Closed
Bug 994045
Opened 11 years ago
Closed 9 years ago
[settings][rtl] Downloads: Restart button overlays download title/name in rtl/right-to-left languages like Arabic
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect, P3)
Tracking
(b2g-v2.2 affected)
RESOLVED
WORKSFORME
Tracking | Status | |
---|---|---|
b2g-v2.2 | --- | affected |
People
(Reporter: aryx, Assigned: nefzaoui)
References
Details
Attachments
(9 files, 1 obsolete file)
Boot2Gecko 1.5.0.0-prerelease 20140407024544 on Geeksphone Keon
After starting a download, the cancel button (after stopping: the restart button) in the Downloads section of Settings overlays the name of the downloaded file.
Assignee | ||
Comment 2•11 years ago
|
||
This fixes both Cancel and Restart buttons and any other button we want to keep LTR'ed in Downloads section.
Kazé, review please? :)
Thanks
Attachment #8404001 -
Flags: review?(fabien)
Comment 3•10 years ago
|
||
Comment on attachment 8404001 [details]
PR to Github
Changing review? to Evelyn since Kaze no longer works here.
Attachment #8404001 -
Flags: review?(fabien) → review?(ehung)
Comment 4•10 years ago
|
||
Ahmed, this actually looks fixed on master, per the attached screenshot. Can you please verify that this is correct and, if so, please mark Resolved Fixed? Thanks!
Flags: needinfo?(nefzaoui.ahmed)
Updated•10 years ago
|
Assignee | ||
Comment 5•10 years ago
|
||
Just checked, The issue still happens.
Attaching new screenshots and PR in a moment..
Flags: needinfo?(nefzaoui.ahmed)
Assignee | ||
Comment 6•10 years ago
|
||
Assignee | ||
Comment 7•10 years ago
|
||
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 8404001 [details]
PR to Github
Rebased.
It's ready for review :)
Thanks!
Comment 9•10 years ago
|
||
Comment on attachment 8404001 [details]
PR to Github
Sorry for my late review. The patch looks good but due to Gaia tree closed before, I'm afraid that you have to rebase the code and submit a PR. Thank you.
Attachment #8404001 -
Flags: review?(ehung)
Assignee | ||
Comment 10•10 years ago
|
||
Done.
review, please?
Thanks.
Attachment #8404001 -
Attachment is obsolete: true
Attachment #8501079 -
Flags: review?(ehung)
Comment 11•10 years ago
|
||
Comment on attachment 8501079 [details]
Link to Github pull-request
Thanks!
Attachment #8501079 -
Flags: review?(ehung) → review+
Comment 12•10 years ago
|
||
Merged into master: https://github.com/mozilla-b2g/gaia/commit/3b81896f04a02697e615fa5390086bd5ecfed84f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 13•10 years ago
|
||
Hi Ahmed
This issue still exist on Flame 2.2:
Gaia-Rev f5b3d1b6cfa3e702033f613915ae637cb735cbfb
Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/bccee1a13ba6
Build-ID 20150119002502
Version 37.0a2
Device-Name flame
FW-Release 4.4.2
Happen time 9:51
Reproduce rate 5/5
Rproduce step:
1.Change the system language to Arabic
2.Try to Download a file from web site
3.When the file is downloading,Launch Settings->Downloads
Actual behavior:The cancel button (after stopping: the restart button) in the Downloads section of Settings overlays the name.
Expected behavior:The cancel button (after stopping: the restart button) in the Downloads section of Settings should not overlays the name.
Attchment logcat.txt and picture 2015-01-19-21-51-40.png 2015-01-20-05-34-02.png
Status: RESOLVED → REOPENED
status-b2g-v2.2:
--- → verified
Flags: needinfo?(nefzaoui.ahmed)
Keywords: verifyme
Resolution: FIXED → ---
Comment 14•10 years ago
|
||
Comment 15•10 years ago
|
||
Comment 16•10 years ago
|
||
Comment 17•10 years ago
|
||
Leaving a NI on delphine to see if this issue exists .
Flags: needinfo?(lebedel.delphine)
Comment 18•10 years ago
|
||
I confirm I still see the issue on today's 2.2, Flame device
Gaia-Rev d6141fa3208f224393269e17c39d1fe53b7e6a05
Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/63b63054948d
Build-ID 20150130002501
Version 37.0a2
Device-Name flame
FW-Release 4.4.2
FW-Incremental 39
FW-Date Thu Oct 16 18:19:14 CST 2014
Bootloader L1TC00011880
Flags: needinfo?(lebedel.delphine)
Updated•10 years ago
|
Priority: -- → P3
Comment 20•9 years ago
|
||
According to the STR in comment 0 and comment 13, this issue cannot be reproduced on latest Flame 2.2&3.0 and N5 2.2&3.0 build.
Actual Result:After starting a download, The cancel button (after stopping: the restart button)in the Downloads section of Settings does not overlay the name of the downloaded file.
See attachment:Restart&Cancel button_Pass.png
Device information:
Flame 2.2 Build ID:20150527002504
Flame 3.0 Build ID:20150527160204
Nexus5 2.2 Build ID:20150527002504
Nexus5 3.0 Build ID:20150527160204
Updated•9 years ago
|
QA Whiteboard: [MGSEI-Triage+]
Comment 21•9 years ago
|
||
Per comment 20 and this issue cannot be reproduced on latest FlameKK&AriesKK v2.5 build by the same STR in comment0 and comment 13.
FlameKK v2.5 build ID (512mb):20151029150245
AriesKK v2.5 build ID: 20151030012032
Status: REOPENED → RESOLVED
Closed: 10 years ago → 9 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•