Closed Bug 994079 Opened 11 years ago Closed 10 years ago

Add integration test for calling mozApps.getSelf() twice in close succession

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.0 S6 (18july)

People

(Reporter: mikehenrty, Unassigned)

References

Details

(Whiteboard: [systemsfe][p=1])

Attachments

(1 file, 1 obsolete file)

Github PR, integration test for mozApps.getSelf
(deleted), text/x-github-pull-request
ferjm
: review+
Details
This was noticed in bug 987458. The most likely cause is https://hg.mozilla.org/mozilla-central/rev/e59ea92c55fc, so I am making this block bug 915598. My guess is we will have to keep a count in the platform of how many listeners we have registered for "Webapps:xxx", and only remove the message listener here [1] when that count reaches 0. 1.) https://hg.mozilla.org/mozilla-central/file/7160658c4be3/dom/apps/src/Webapps.js#l56
Fernando, you worked on bug 915598. Do you agree with the approach mentioned in comment 0? Does the bug report make sense?
Flags: needinfo?(ferjmoreno)
Component: DOM → DOM: Apps
Note - we're probably going to want to get a test for this.
Attached file Github PR for Gaia Integration Test (obsolete) (deleted) —
Here's an integration test in Gaia that demonstrates the problem.
Sorry for the silent ni? on me. I couldn't reply at that moment and I set the flag on me so I don't remember to reply. So I think the approach in comment 0 is correct, but I'd do that in the DOMRequestIPCHelper [1] instead of the WebApps implementation. [1] https://mxr.mozilla.org/mozilla-central/source/dom/base/DOMRequestHelper.jsm#105
Flags: needinfo?(ferjmoreno)
Assignee: nobody → mhenretty
Assignee: mhenretty → nobody
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Well now that this was fixed in bug 1026737, we should probably go ahead and add the integration test I made for this. Re-opening this bug for that purpose. I'll create a new PR, so that we can run it on gaia-try as well as travis.
Status: RESOLVED → REOPENED
Component: DOM: Apps → Gaia::System
Product: Core → Firefox OS
Resolution: DUPLICATE → ---
Summary: Calling mozApps.getSelf() twice in close succession will cause the second request to fail → Add integration test for calling mozApps.getSelf() twice in close succession
Whiteboard: [systemsfe][p=1]
Target Milestone: --- → 2.0 S6 (18july)
Fernando, you are familiar with this situation and are a good reviewer :) Would you mind taking a look at this integration test for mozApps.getSelf()? FWIW this used to fail before bug 1010690, but now it passes locally for me.
Attachment #8404104 - Attachment is obsolete: true
Attachment #8452067 - Flags: review?(ferjmoreno)
**Meant to say, this used to fail before bug bug 1026737.
Attachment #8452067 - Flags: review?(ferjmoreno) → review+
master: https://github.com/mozilla-b2g/gaia/commit/4233e61019794e3bcd35c3aa5b80c6211e1be652
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: