Closed Bug 994438 Opened 11 years ago Closed 11 years ago

Facebook Links to websites severely affects Tarako performance and/or crashes app

Categories

(Tech Evangelism Graveyard :: Preinstalled B2G Apps, defect, P1)

Other
Gonk (Firefox OS)
defect

Tracking

(b2g-v1.3T fixed)

RESOLVED FIXED
Tracking Status
b2g-v1.3T --- fixed

People

(Reporter: relaas, Assigned: Harald, NeedInfo)

References

()

Details

(Whiteboard: [c=memory p= s= u=tarako])

Attachments

(1 file)

Steps for reproduction; - Launch FB app on Tarako Device - Attempt to open an external link within a post (either to a website or video) - Observe performance degradation and frequent crashing.
blocking-b2g: --- → 1.3T?
What kind of crash? what is crashing? In any case that would be a meta bug and we don't block on meta bugs.
blocking-b2g: 1.3T? → ---
Can we get some logcats and/or more information please?
Flags: needinfo?(telin)
Summary: Facebook Links to websites severely effects Tarako perofrmance and/or crashes app → Facebook Links to websites severely affects Tarako performance and/or crashes app
Flags: needinfo?(hkirschner)
Keywords: perf
Priority: -- → P4
Whiteboard: [c= p= s= u=]
Flags: needinfo?(telin)
(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #2) > Can we get some logcats and/or more information please? Harald is providing this information.
Attached file logcat.txt (deleted) —
verify with today's daily build, FB links to external link will be killed by LMK Gaia 1177a857a3caeb8fd1feae94c83298a9144c2ff5 Gecko https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/d28bb1e73b91 BuildID 20140504014000 Version 28.1
Nominating - FB is supposed to be core functionality.
blocking-b2g: --- → 1.3T?
trigae: facebook is a must have for tarako. 1.3T+
blocking-b2g: 1.3T? → 1.3T+
Can we get clearer STR, expected/actual results here?
Keywords: qawanted
I reproduced this issue with the following steps: 1) Update a Tarako to BuildID: 20140502014001 2) Download and install the Facebook app. 3) Log into a Facebook account. 4) Select a Facebook post with an external link to a large website (Music website, Movie information website) Actual: The page loads slowly and crashes. Expected: The page loads normally and does not crash. 1.3t Environmental Variables: Device: Tarako BuildID: 20140502014001 Gaia: a8e0ff550de08e58e4bf75af3cecf175b9b71e70 Gecko: 71790bf476cb Version: 28.1 Firmware Version: sp6821a
Keywords: qawanted
QA Contact: jharvey
Going to bounce this back into perf triage as product seems to think this is high priority for Tarako.
Priority: P4 → --
Keywords: footprint
OS: Windows 7 → Gonk (Firefox OS)
Hardware: x86_64 → Other
Whiteboard: [c= p= s= u=] → [c=memory p= s= u=tarako]
Severity: normal → blocker
Priority: -- → P1
Whiteboard: [c=memory p= s= u=tarako] → [c=memory p= s= u=tarako] [MemShrink]
Harald, Assigning this to you to get some profiling[1] from Partner Engineering. Please attach the profile and comment on whether it points at an app-specific or platform-specific cause. If your team needs help on this please let us know. Thanks, Mike [1] https://developer.mozilla.org/en-US/docs/Performance/Profiling_with_the_Built-in_Profiler#Profiling_Boot_to_Gecko_%28with_a_real_device%29
Assignee: nobody → hkirschner
Status: NEW → ASSIGNED
Whiteboard: [c=memory p= s= u=tarako] [MemShrink] → [c=memory p= s= u=tarako] [MemShrink:P2]
Colby, it seems like FB is opening links in popups rather than the browser app by (guessing here) calling `window.open` with a window-name parameter. This causes the app to add up all the memory and quickly getting killed.
Flags: needinfo?(hkirschner) → needinfo?(colby)
Unblocking this from the b2g flag since this is a TE issue.
Blocks: b2g-facebook
blocking-b2g: 1.3T+ → ---
Component: Performance → Preinstalled B2G Apps
Keywords: footprint, perf
Product: Firefox OS → Tech Evangelism
Whiteboard: [c=memory p= s= u=tarako] [MemShrink:P2] → [c=memory p= s= u=tarako]
Harald, yeah we use window.open. What's a better way for Firefox? Using an activity to open in the Browser?
Flags: needinfo?(colby) → needinfo?(hkirschner)
Colby, do you call window.open with a name parameter? Setting the name to '_blank' should fix it.
Flags: needinfo?(hkirschner) → needinfo?(colby)
Ah, I see. I think I misread your comment. We weren't passing a name param, just calling window.open(href).
Flags: needinfo?(colby)
Using '_blank' as name will fix this (by opening the link in the browser) and therefor give the expected behavior. On other platforms it should give the same behavior. Do you see any downsides I missed or can you confirm that this will be fixed?
Flags: needinfo?(colby)
Nope, that seems fine. The fix will be out next Tuesday.
Flags: needinfo?(colby)
Looking out for it today, nothing so far.
Flags: needinfo?(nhirata.bugzilla)
Sorry my mistake. The release was pushed back this week because of Memorial Day. It should be live now.
For Tarako, looks like we can go to browser links, having said that the facebook app will shut down and you will have to scroll back to where you were before you clicked the link. Is there any chance we could have some sort of option to store the position in the facebook app/page like a cookie or something? I suppose that's a different bug/feature request.
Flags: needinfo?(colby)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: needinfo?(nhirata.bugzilla)
Resolution: --- → FIXED
Product: Tech Evangelism → Tech Evangelism Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: