Amy Lee [:amylee] UX Reporter
	Description • 10 years ago

The bluetooth icon looks too small and the text between the hairlines should be centered.

Steps to reproduce:

1. Open music app
2. Select song to play
3. Select share
4. Select Bluetooth Transfer

	Pavel Ivanov [:ivanovpavel][:pivanov] UX Assignee
	Comment 1 • 10 years ago

Hey Amy can you provide the icon?

	Amy Lee [:amylee] UX Reporter
	Comment 2 • 10 years ago

Hi Pavel, 

I've attached an svg of the icon. Let me know if you need it in any other format. I've also attached a screen for placement. The icon and text should be vertically centered to the row. 

Thanks!

	Amy Lee [:amylee] UX Reporter
	Comment 3 • 10 years ago

Screenshot for correct placement

	Pavel Ivanov [:ivanovpavel][:pivanov] UX Assignee
	Comment 4 • 10 years ago

Hey Amy,

can you give me the size of the icon?

	Amy Lee [:amylee] UX Reporter
	Comment 5 • 10 years ago

(In reply to Pavel Ivanov [:ivanovpavel][:pivanov] from comment #4)
> Hey Amy,
> 
> can you give me the size of the icon?

Hi Pavel, 

It's 10px x 21px

	Pavel Ivanov [:ivanovpavel][:pivanov] UX Assignee
	Comment 6 • 10 years ago

Hey Amy ... are you sure that the size need to be 10x21 pixels? because current icon is 64x64 pixels and the real height of the Bluetooth Icon is ~24x46 pixels? and we need to make it bigger right?

	Amy Lee [:amylee] UX Reporter
	Comment 7 • 10 years ago

(In reply to Pavel Ivanov [:ivanovpavel][:pivanov] from comment #6)
> Hey Amy ... are you sure that the size need to be 10x21 pixels? because
> current icon is 64x64 pixels and the real height of the Bluetooth Icon is
> ~24x46 pixels? and we need to make it bigger right?

Hi Pavel, 

Apologies, the icon should be 22x46px based on a 320x480 screen.

	Pavel Ivanov [:ivanovpavel][:pivanov] UX Assignee
	Comment 8 • 10 years ago

Hey Amy,
if we use 22x46 pixels for the icon it will be the same size as is now. I think that you want bigger icon?

	Amy Lee [:amylee] UX Reporter
	Comment 9 • 10 years ago

(In reply to Pavel Ivanov [:ivanovpavel][:pivanov] from comment #8)
> Hey Amy,
> if we use 22x46 pixels for the icon it will be the same size as is now. I
> think that you want bigger icon?

Hi Pavel, 

I measured the icon as 22x46px on a 320x480 screen and on flame size it's 33x69.

	Pavel Ivanov [:ivanovpavel][:pivanov] UX Assignee
	Comment 10 • 9 years ago

Hey Amy,

I just take a shot from my device. I think it works fine now. What do you think?

	Amy Lee [:amylee] UX Reporter
	Comment 11 • 9 years ago

(In reply to Pavel Ivanov [:ivanovpavel][:pivanov] from comment #10)
> Created attachment 8650648 [details]
> Shot from Device
> 
> Hey Amy,
> 
> I just take a shot from my device. I think it works fine now. What do you
> think?

Hi Pavel, 

It still looks too small. I attached a mock of how the icon should look in this bug. https://bug994691.bmoattachments.org/attachment.cgi?id=8516809

Thanks

	Pavel Ivanov [:ivanovpavel][:pivanov] UX Assignee
	Comment 12 • 9 years ago

What do you think?

	Amy Lee [:amylee] UX Reporter
	Comment 13 • 9 years ago

Comment on attachment 8650686 [details]
Shot from Device

Can you reduce the height by 2px so it's aligned to the top and bottom of the text height? Thanks!

	Pavel Ivanov [:ivanovpavel][:pivanov] UX Assignee
	Comment 14 • 9 years ago

Like this one?

	Amy Lee [:amylee] UX Reporter
	Comment 15 • 9 years ago

(In reply to Pavel Ivanov [:ivanovpavel][:pivanov] from comment #14)
> Created attachment 8650701 [details]
> Shot from Device
> 
> Like this one?

Looks good. Thanks!

	Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)
	Comment 18 • 9 years ago

(In reply to Pavel Ivanov [:ivanovpavel][:pivanov] UX from comment #17)
> Created attachment 8651140 [details]
> patch for Gaia/master

Opps, I'm not the right person to review this. Forward to Fred.

	gasolin@mozilla.com
	Comment 19 • 9 years ago

review blocked by bug 1197735 since it make the UI not shown

	gasolin@mozilla.com
	Comment 20 • 9 years ago

Comment on attachment 8651140 [details]
patch for Gaia/master

looks good to me, though I feel the BT icon is a bit longer at the bottom on flame

	Pavel Ivanov [:ivanovpavel][:pivanov] UX Assignee
	Comment 22 • 9 years ago

Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/e69f2c86b931b723dd405115e33a1d02e6c5f5e6