Closed Bug 994710 Opened 10 years ago Closed 10 years ago

[Settings] Keyboards: Setting icons on the right need to be removed.

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Carol, Assigned: mihai)

References

Details

(Whiteboard: ux-most-wanted)

Attachments

(2 files)

Settings_keyboard option.png
(deleted), image/png
Details
Pull Request #18260 - [Settings] Remove icons from Keyboard installed input methods
(deleted), text/x-github-pull-request
arthurcc
: review+
Details
Attached image Settings_keyboard option.png (deleted) — 
In Keyboards option: doesn't need the setting icons on the right. Need to be removed.
Whiteboard: ux-most-wanted
Blocks: 994991
Assignee: nobody → mihai
Comment on attachment 8405815 [details]
Pull Request #18260 - [Settings] Remove icons from Keyboard installed input methods

Thanks for the patch, Mihai. Let's remove all "keyboard-menuItem" class names in settings app as it looks like we don't need them anymore.
Attachment #8405815 - Flags: review?(arthur.chen)
Comment on attachment 8405815 [details]
Pull Request #18260 - [Settings] Remove icons from Keyboard installed input methods

Removed all occurrences of `keyboard-menuItem`. Thanks for the feedback, Arthur!
Attachment #8405815 - Flags: review?(arthur.chen)
Comment on attachment 8405815 [details]
Pull Request #18260 - [Settings] Remove icons from Keyboard installed input methods

r=me, thank you!
Attachment #8405815 - Flags: review?(arthur.chen) → review+
Thanks Arthur, landed on master:
https://github.com/mozilla-b2g/gaia/commit/7bca1200a016b715d106bd2e7e0889d44b3d9c22
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: