Eitan Isaacson [:eeejay] Reporter
	Description • 10 years ago

By swiping through the interface, the user could being up all the different screens that are transformed out of view.

	Etienne Segonzac (:etienne)
	Comment 2 • 10 years ago

Comment on attachment 8425155 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19398

Redirecting to a contact peer.

BTW looks like this is breaking some marionette-js tests.

	Francisco Jordano [:arcturus] [:francisco]
	Comment 3 • 10 years ago

Comment on attachment 8425155 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19398

Almost there, left some comments on github.

Mainly we have a problem, of going throug a pathd of the code that can try to execute a null callback.

But tiny change and we are ready to land this. Ask me for review once the changes are applied.

Thanks a lot for the collaboration!

	Francisco Jordano [:arcturus] [:francisco]
	Comment 4 • 10 years ago

Forgot to mention, can you add some unit test (or reuse the current ones) to check when the class 'current' should be or not be there?

Thanks!

	Eitan Isaacson [:eeejay] Reporter
	Comment 5 • 10 years ago

Comment on attachment 8425155 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19398

I had to redo a lot of unit tests. Since we need to be completely async, and waif for callbacks, having global variables for "current" and "next" does not work well.

	Francisco Jordano [:arcturus] [:francisco]
	Comment 6 • 10 years ago

Relaunching the marionette tests

	Eitan Isaacson [:eeejay] Reporter
	Comment 7 • 10 years ago

Green.

	Francisco Jordano [:arcturus] [:francisco]
	Comment 8 • 10 years ago

Comment on attachment 8425155 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19398

German I know you were the last one doing a big refactor in the navigation object.

Would you mind giving feedback about the patch?

I already did the review but will appreciate your feedback here.

	Eitan Isaacson [:eeejay] Reporter
	Comment 9 • 10 years ago

German, any chance for feedback soon?

	Germán Toro del Valle (:gtorodelvalle)
	Comment 10 • 10 years ago

Comment on attachment 8425155 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19398

Hi guys! Sorry for the delay, mainly to Eitan :-) Looking good to me and much cleaner than the previous code so congrats! ;-)

	Francisco Jordano [:arcturus] [:francisco]
	Comment 11 • 10 years ago

Relaunch travis jobs to land this.

	Francisco Jordano [:arcturus] [:francisco]
	Comment 12 • 10 years ago

Adding my self as needinfo to remember to land this :)

	Francisco Jordano [:arcturus] [:francisco]
	Comment 13 • 10 years ago

\o/ green travis!

Thanks a lot Eitan

	Francisco Jordano [:arcturus] [:francisco]
	Comment 14 • 10 years ago

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/a4e2793dbee7b71bcf4786fb37be7369b2b34cfb