The value of |dataInfo.connected| means the "default" connection is established or not. And right now we will update |dataInfo.connected| in DataConnectionHandler in some case. This makes bug 939046 hard to move on. So I would like to clean up it in this bug.

We can update |dataInfo.connected| by monitoring 'network-active-changed' and checking |NetworkManager.active| [1]. But right now, if active becomes to null, there is no 'network-active-changed' propagated. We need to fix this first. [1] http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/nsINetworkManager.idl?from=nsINetworkManager.idl#147-153

(In reply to Edgar Chen [:edgar][:echen] from comment #1) > Created attachment 8406088 [details] [diff] [review] > WIP, Patch, v1 > > We can update |dataInfo.connected| by monitoring 'network-active-changed' > and checking |NetworkManager.active| [1]. > > But right now, if active becomes to null, there is no > 'network-active-changed' propagated. We need to fix this first. Filed a bug for this, bug 996409. > > [1] > http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/ > nsINetworkManager.idl?from=nsINetworkManager.idl#147-153

Comment on attachment 8406088 [details] [diff] [review] WIP, Patch, v1 Review of attachment 8406088 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/RadioInterfaceLayer.js @@ +2425,4 @@ > dataInfo.connected = false; > + if (gNetworkManager.active && > + gNetworkManager.active.type === > + Ci.nsINetworkInterface.NETWORK_TYPE_MOBILE) { We need to consider |serviceId| as well, will address it in next version. @@ +3341,5 @@ > + let dataInfo = this.rilContext.data; > + let connected = false; > + if (gNetworkManager.active && > + gNetworkManager.active.type === > + Ci.nsINetworkInterface.NETWORK_TYPE_MOBILE) { ditto

Address comment #3.

Comment on attachment 8408089 [details] [diff] [review] Patch, v2 Review of attachment 8408089 [details] [diff] [review]: ----------------------------------------------------------------- Thank you :) ::: dom/system/gonk/RadioInterfaceLayer.js @@ +3346,5 @@ > + connected = true; > + } > + if (dataInfo.connected !== connected) { > + dataInfo.connected = connected; > + gMessageManager.sendMobileConnectionMessage("RIL:DataInfoChanged", Eventually, RadioInterface won't need to observe this topic, and rilContext.data won't care. Let's do the cleanup in bug 843452, then the patch looks fine now.

Comment on attachment 8408089 [details] [diff] [review] Patch, v2 Review of attachment 8408089 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/RadioInterfaceLayer.js @@ +3349,5 @@ > + dataInfo.connected = connected; > + gMessageManager.sendMobileConnectionMessage("RIL:DataInfoChanged", > + this.clientId, dataInfo); > + } > + break Oh, missing a semicolon here, my bad. :(

Address comment #6.

Try result: https://tbpl.mozilla.org/?tree=Try&rev=c203e7ad96a6