Closed Bug 995156 Opened 11 years ago Closed 3 years ago

Hang typing into the address bar after visiting very long URLs

Categories

(Core :: Layout: Text and Fonts, defect)

x86
macOS
defect
Not set
critical

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: jwatt, Unassigned)

References

Details

(Keywords: hang)

Attachments

(2 files)

I've recently been experiencing occasional 100% CPU hangs when typing into the address bar, forcing me to kill and restart Firefox. Worse is that from that day forward typing the same two or three character sequence into the address bar will cause Firefox to hang again. It turns out this happens after you visit a very long URL, when you later type into the address bar an the suggestion list tries to include that long URL. In my case this most recently happened after visiting a reftest-analyzer link from TBPL results. More specifically for a Windows "R" failure from: https://tbpl.mozilla.org/?tree=Try&rev=cc042860ee89 The URL was almost 8 MB in length, and we end up hanging in text run code trimming white space when I type "que" into the address bar. To stop the hangs from occurring I had to figure out which long URL I had visited and then go into |History > Show All History| and search for and delete that URL so that it would no longer appear in the address bar suggestions list.
This is in a release build.
Component: Layout: Text → Location Bar
Depends on: 722323
Product: Core → Firefox
While limiting the length of the autocomplete results would prevent us hitting this bug, this issue should be considered separately. Something is rotten in the textrun code if we're hanging on 8 MB strings.
Component: Location Bar → Layout: Text
No longer depends on: 722323
Product: Firefox → Core
Yeah, that sounds like we have an inefficiency somewhere. Could you grab a profile of the hang?
Attached file profile as text file (deleted) —
Attached file profile as Instruments .trace.zip (deleted) —
Bug 907001 is on file for essentially the same issue, but is currently a front-end bug tracking limiting the results we display.
Blocks: 907001

Hello! I will close this issue since there was no activity in the past years and also that this issue doesn't occur in the latest fx versions of firefox. If this issue is still valid please feel free to reopen it.

Thank you and have a nice day!

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: