Oleg Zasypkin [:azasypkin] Reporter
	Description • 10 years ago

Using iframe to host attachment inside contenteditable compose field works well, but involves a bunch of magic, has bigger memory footprint and makes code more complex than it could be. 

We should think of alternative ways to do this. One of ideas is to draw thumbnail+filename+filesize into a single canvas and use toDataURL instead of iframe.

See bug 889899 for more details on reasons behind iframe.

	Julien Wajsberg [:julienw]
	Comment 1 • 10 years ago

(In reply to Oleg Zasypkin [:azasypkin] from comment #0)
> 
> We should think of alternative ways to do this. One of ideas is to draw
> thumbnail+filename+filesize into a single canvas and use toDataURL instead
> of iframe.

Or just display the canvas itself ;)

	Oleg Zasypkin [:azasypkin] Reporter
	Comment 2 • 10 years ago

(In reply to Julien Wajsberg [:julienw] from comment #1)
> (In reply to Oleg Zasypkin [:azasypkin] from comment #0)
> > 
> > We should think of alternative ways to do this. One of ideas is to draw
> > thumbnail+filename+filesize into a single canvas and use toDataURL instead
> > of iframe.
> 
> Or just display the canvas itself ;)

Yep, should also work!

	Oleg Zasypkin [:azasypkin] Reporter
	Comment 3 • 10 years ago

One more approach that we probably can try: https://developer.mozilla.org/en-US/docs/HTML/Canvas/Drawing_DOM_objects_into_a_canvas

	Julien Wajsberg [:julienw]
	Comment 4 • 8 years ago

Mass closing of Gaia::SMS bugs. End of an era :(

	Julien Wajsberg [:julienw]
	Comment 5 • 8 years ago

Mass closing of Gaia::SMS bugs. End of an era :(