Closed
Bug 996346
Opened 11 years ago
Closed 5 years ago
Make nsXBLBinding's strong reference to the XBLDocumentInfo less odd
Categories
(Core :: XBL, defect)
Core
XBL
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: mccr8, Unassigned)
Details
Right now, nsXBLBinding calls NS_ADDREF(mPrototypeBinding->XBLDocumentInfo()) in its ctor, NS_RELEASE in its dtor, and does a Traverse (but not an Unlink) of mPrototypeBinding->XBLDocumentInfo(). There's a comment in Unlink: "XXX Probably can't unlink mPrototypeBinding->XBLDocumentInfo(), because mPrototypeBinding is weak." This comment seems bogus, because we do the release in the dtor without any kind of null check. In some limited local testing, making this into a regular refPtr field that is unlinked seems to at least sort of work.
Comment 2•5 years ago
|
||
XBL is now disabled in Firefox (Bug 1583314) and is in the process of being removed from Gecko (Bug 1566221), so closing bugs requesting changes to its implementation as wontfix.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•