Francesco Lodolo [:flod] Reporter
	Description • 10 years ago

Noticed today on master when opening browser.app

The main title is not localized (see screenshot). Setting component and dependency based on the assumption that is related to the l10n.js refactor

	Axel Hecht [:Pike]
	Comment 1 • 10 years ago

Which build is that? Asking because I know it's been broken on the desktop builds before, due to bad packaging of shared branding.

	Francesco Lodolo [:flod] Reporter
	Comment 2 • 10 years ago

This happens on both Hamachi and Keon, today's build, flashing over my version of Gaia with the usual script. Same happens in Nightly running a Gaia profile.

	Francesco Lodolo [:flod] Reporter
	Comment 3 • 10 years ago

Now that I think more about it, I've seen this before last week.
In fact, if I open FTU, I have the same problem.

Tried flashing again but I have the same issue.

	Francesco Lodolo [:flod] Reporter
	Comment 4 • 10 years ago

Relevant piece of make log

~/moz/gaia/shared/locales/branding/official/branding.it.properties could not be found.
/build_stage/communications/ftu/index.html: [l10n] [it]: 3 missing in the visible DOM: n, brandShortName, url
/build_stage/communications/ftu/index.html: [l10n] [it]: 3 missing compared to en-US: brandShortName, browserBrandShortName, browserBrandFullName

Not sure where to move this bug at this point.

	Francesco Lodolo [:flod] Reporter
	Comment 5 • 10 years ago

This doesn't happen if I flash the official build for Hamachi (20140414160205).

Command I'm using to flash Gaia is

make clean && PRODUCTION=1 make install-gaia MAKECMDGOALS=production MOZILLA_OFFICIAL=1 GAIA_KEYBOARD_LAYOUTS=en,it GAIA_DEFAULT_LOCALE=it LOCALES_FILE=locales/languages_all.json LOCALE_BASEDIR=locales/ DEVICE_DEBUG=1

	Francesco Lodolo [:flod] Reporter
	Comment 6 • 10 years ago

Yuren, is this related to the build problem? Any idea who could look into this?

	Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode) Assignee
	Comment 7 • 10 years ago

Francesco, I used this command to make with Italian but can't reproduce this issue, could you give me your command which can reproduce it?

LOCALES_FILE=../l10n/languages.json LOCALE_BASEDIR=../l10n make

there are language.json with Italian and it directory which download from http://hg.mozilla.org/gaia-l10n in l10n directory.

	Francesco Lodolo [:flod] Reporter
	Comment 8 • 10 years ago

The full command I use is reported in comment 5 (I actually use this script https://github.com/flodolo/scripts/blob/master/gaia/flash_gaia.sh)

make clean && PRODUCTION=1 make install-gaia MAKECMDGOALS=production MOZILLA_OFFICIAL=1 GAIA_KEYBOARD_LAYOUTS=en,it GAIA_DEFAULT_LOCALE=it LOCALES_FILE=locales/languages_all.json LOCALE_BASEDIR=locales/ DEVICE_DEBUG=1

I've received reports from other people having the same issue.

	Francesco Lodolo [:flod] Reporter
	Comment 9 • 10 years ago

I see you have a completely different image in browser, so it's probably not using brandShortName at all (MOZILLA_OFFICIAL?)

	Francesco Lodolo [:flod] Reporter
	Comment 10 • 10 years ago

Locales don't have a branding/official folder, just branding/unofficial
https://hg.mozilla.org/gaia-l10n/en-US/file/3a3a34244293/shared/branding

I guess that's the issue here.

	Axel Hecht [:Pike]
	Comment 11 • 10 years ago

AFAICT, the issue is that we're copying over shared/locales/branding without taking either the official or unofficial part of it into build_stage.
Or we'd need to reference either in build_stage/.../shared/locales/branding.ini, but the references in there don't match the official and unofficial subdirs there.

Don't recall if my build_stage locally is one for profile-test or profile-debug

	Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode) Assignee
	Comment 12 • 10 years ago

thanks, I can reproduce it with |LOCALES_FILE=../l10n/languages.json LOCALE_BASEDIR=../l10n  GAIA_DEFAULT_LOCALE=it make|.

	Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode) Assignee
	Comment 13 • 10 years ago

root cause should be we don't embed {{browserBrandShortName}} for data-l10n-id "browser". 

browser/index.html in zip for three condition:

make:
[o] <h1 data-l10n-id="browser">Web Browser</h1>

GAIA_DEFAULT_LOCALE=zh-TW make:
[o] <h1 data-l10n-id="browser">網頁瀏覽器</h1>

GAIA_DEFAULT_LOCALE=it LOCALE_BASEDIR=<L10N_DIR> make
[x] <h1 data-l10n-id="browser">{{browserBrandShortName}}</h1>

	Francesco Lodolo [:flod] Reporter
	Comment 14 • 10 years ago

Note that we have the same problem in FTU, and I guess in other places where we use that variable (system, settings, but I should check)
http://transvision.mozfr.org/?recherche=brandshortname&repo=gaia&sourcelocale=en-US&locale=en-US&search_type=strings

	Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode) Assignee
	Comment 15 • 10 years ago

I think the root cause is we don't copy right branding files from l10n directory, I'll keep investigating tomorrow.

	Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode) Assignee
	Comment 16 • 10 years ago

francesco, could you test this pr if it can solve this issue? noted we still can reproduce this issue with MOZILLA_OFFICIAL=1 because we don't have it/shared/branding/official/branding.properties, please file a follow up bug to fix it for l10n repository.

George, could you review this pr? thanks!

	Francesco Lodolo [:flod] Reporter
	Comment 17 • 10 years ago

Comment on attachment 8444925 [details]
github PR: https://github.com/mozilla-b2g/gaia/pull/20913

With the patch applied, and dropping MOZILLA_OFFICIAL=1, I get B2G OS in browser and FTU.

> noted we still can reproduce this issue with MOZILLA_OFFICIAL=1 
> because we don't have it/shared/branding/official/branding.properties, 
> please file a follow up bug to fix it for l10n repository.

I'm not sure if this should be fixed at l10n level (adding strings) or build level (just use en-US values). Pike, what do you think?

https://bitbucket.org/pike/gaiaconv/src/44483e5e7ebd8e46f0f4d590c48525a9f70cb2ac/gaiaconv/filemap.py?at=default#cl-45

	Axel Hecht [:Pike]
	Comment 18 • 10 years ago

The official branding is not part of l10n by design, to avoid localizers fudging with our trademarks.

Our work here should probably keep it that way. Otherwise, we'd need to open a can of worms with the brand people.

	Francesco Lodolo [:flod] Reporter
	Comment 19 • 10 years ago

That's what I thought.

@Yuren
Should I file a bug to make the build system always use en-US /branding/official with MOZILLA_OFFICIAL=1?

	Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode) Assignee
	Comment 20 • 10 years ago

Francesco, I updated my pr so now we are good both for MOZILLA_OFFICIAL=1|0 :D

so we don't need to file another bug.

	Francesco Lodolo [:flod] Reporter
	Comment 21 • 10 years ago

(In reply to Yuren [:yurenju] from comment #20)
> Francesco, I updated my pr so now we are good both for MOZILLA_OFFICIAL=1|0

I tried the patch, but it doesn't work for me. Is it already updated on GH?

Also in the log I still see a bunch of

[multilocale] Properties file not found: /Users/flodolo/moz/gaia/locales/it/shared/branding/official/branding.properties

	Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode) Assignee
	Comment 22 • 10 years ago

what command do you use? like command on comment 8?

I will take a look tomorrow.

	Francesco Lodolo [:flod] Reporter
	Comment 23 • 10 years ago

Yes, the command is in comment 8.

	(Inactive after June) George Duan [:gduan] [:喬智]
	Comment 24 • 10 years ago

Comment on attachment 8444925 [details]
github PR: https://github.com/mozilla-b2g/gaia/pull/20913

Patch looks good to me. I also tried to copy unofficial folder to official with command from comment 8, and it works fine.

r=gduan

	Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode) Assignee
	Comment 25 • 10 years ago

Hi Francesco,

Just like George and Pike said, we won't have translation for official branding but the mechanism works if we have translation for official branding, so I will land this pr soon.

	Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode) Assignee
	Comment 26 • 10 years ago

merged.

https://github.com/mozilla-b2g/gaia/commit/f99a96a063f7569c3ba4921757b48e0e303884f1

	Francesco Lodolo [:flod] Reporter
	Comment 27 • 10 years ago

(In reply to Yuren [:yurenju] from comment #25)
> Just like George and Pike said, we won't have translation for official
> branding but the mechanism works if we have translation for official
> branding, so I will land this pr soon.

Bug subject says " {{browserBrandShortName}} is displayed instead of Firefox OS (browser, FTU)". That's not fixed for MOZILLA_OFFICIAL=1, because we won't have /branding/official in l10n repositories.

I'm fine with you landing this patch, but either you change this bug subject and I file a new one for MOZILLA_OFFICIAL=1, or this bug is actually not fixed.

	Axel Hecht [:Pike]
	Comment 28 • 10 years ago

flod, I'm surprised that runtime fallback wouldn't work for official branding. I'll have hardly any time for testing myself in the next few days.

Or is this only a problem if you set GAIA_DEFAULT_LOCALE to non-en-US?

	Francesco Lodolo [:flod] Reporter
	Comment 29 • 10 years ago

(In reply to Axel Hecht [:Pike] from comment #28)
> flod, I'm surprised that runtime fallback wouldn't work for official
> branding. I'll have hardly any time for testing myself in the next few days.
> 
> Or is this only a problem if you set GAIA_DEFAULT_LOCALE to non-en-US?

Apparently yes.

GAIA_DEFAULT_LOCALE=it
Flash the device, browser shows {{browserBrandShortName}}
Switch to English, browser shows "Firefox"
Switch back to Italian, browser shows {{browserBrandShortName}}

If I remove GAIA_DEFAULT_LOCALE completely, I get "Firefox" correctly even if the phone starts in Italian.