Closed
Bug 996742
Opened 10 years ago
Closed 10 years ago
CompositableHost.cpp forward-declares Matrix4x4 in wrong namespace
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
nrc
:
review+
|
Details | Diff | Splinter Review |
While trying to implement bug 995411 I made some local changes and my build on mac desktop broke (also same error showed up all over my try push). The problem seems to be that CompositableHost.cpp has a forward-declare of Matrix4x4 in mozilla::layers when it actually exists in mozilla::gfx. This forward declare isn't used in the file itself, but because of unified builds it causes a conflict elsewhere in the code.
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8407002 [details] [diff] [review] Patch Try build including this change pending at https://tbpl.mozilla.org/?tree=Try&rev=98ebef777331 (can't see it in the pushlog because I pushed it a different try push just before).
Attachment #8407002 -
Flags: review?(ncameron)
|
||
Updated•10 years ago
|
Summary: CompositableHost.cpp doesn't play nicely with unified builds → CompositableHost.cpp forward-declares Matrix4x4 in wrong namespace
|
||
Updated•10 years ago
|
Attachment #8407002 -
Flags: review?(ncameron) → review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e6a039374b1
Keywords: checkin-needed
|
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8e6a039374b1
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•