With the current build, the initial size of Offline and Diskspace window on mail account manager is too small for Japanese build. The strings and Select button on that window are truncated. Although the window can be manually resized by users, it will give users bad first impression of the product. The initial size of the window needs to be externalized to the resource file, so localization engineers can adjust the initial size of that window in language packs. I'll attach a screen shot of Japanese build to illustrate the problem.

A good example is the preferences dialog which has the externalized initial size valuable in the dtd file.

various related bugs to offline and diskspace panel are bug 66917, bug 81753, bug 80134, and I think this is main one: bug 84692. Maybe this bug is dupe of that one?

I'd say its a dup of bug 84692. To much stuff on the panel and things being cut off with current default size.

Please note that we are requiring the default size be externalized to a resource file, since the default sizes for localized builds could be different with the one for English build. If this bug is resolved as a dup of bug 84692, please make sure the default size goes to a resource file when a fix for bug 84692 is checked in.

>Please note that we are requiring the default size be externalized to a >resource file, since the default sizes for localized builds could be different >with the one for English build. Wouldn't you want this to apply to All panels then instead of just this one? In case any panel grows too large?

Yes, we'd like to have this applied to all the panels, and we are more concerned about if we can adjust the default size w/o modifying the code in localized builds.

ji - can you check this one to see if this is still true in 6.2?

The problem still exists in 6.2.

reassigning to sean su

Nominate nsbeta1.

I will take a look and try to fix it now.

Discussed in 2/28/02 Mail & News bug meeting. Decisions was to minus this bug, because it's not a showstopper for the release, but we will accept the patch if it gets in in time. Reassigining to yxia

ssu, would you please review the patch, this kind of bug is critical for our l10n. Thanks.

Comment on attachment 71777 [details] [diff] [review] Patch to move the size value of account manager dialog into dtd. r=ssu

mscott and bienvenu, we need a sr now. thanks.

did you have to do something similar for other dialogs, like the pref window? I'm curious to know what ben / blake think about this. I'm ok with this, especially given the comments about how for US builds, we should leave the value alone, but for other languages, this is the only way (short of picking a smaller font?) to fix this.

Comment on attachment 71777 [details] [diff] [review] Patch to move the size value of account manager dialog into dtd. blake says: "yeah, that's what prefs does too. it's not a real scalable solution but i guess it's ok for now." It forces the localizers to pick a better size, if the default (english) size is too small. sr=sspitzer

Thanks a lot, everybody, it benefits our l10n a lot. rchen, do you mind to check it in now? I don't have the checkin account yet;-)

ssu, can you help ying to checkin?

Comment on attachment 71777 [details] [diff] [review] Patch to move the size value of account manager dialog into dtd. a=asa (on behalf of drivers) for checkin to 0.9.9 and the Mozilla trunk.

patch checked into the 0.9.9 branch and the trunk.

Using US Commercial trunk builds: 2002030403 on NT 4.0 2002030406 on linux 2.2 2002030412 on Mac 9.2.2 2002030403 on MAC 10.1.3 The offline and disk space panel for mail and news looks the same for US builds. Tried both Classic and Modern theme. The fix didn't help the offline & diskspace panel bugs (bug 96541 or bug 84692) but then i don't think the fix was designed to fix US builds. Does someone on International QA team want to verify that the International Builds are fixed? Then mark it as verified? Or if someone wants to show me, I can try international builds. Leaving as Resolved until International builds are verified.

This bug fix does nothing about US build, but just put the dialog layout numbers into the language pack, so the localizer can easily change the dialog size to fit their language. If you see anything wrong with the US build, file bugs against US build please.

Tested 03-04 US build, now we can change this dialog size in the language pack. You can verify this bug now.

ok, marking as verified.