As seen on bug 996027 we have to fake the 'weave:service:setup-complete' notification for Weave. This is only necessary for the old sync authentication schema. For Firefox Accounts it is not necessary. Maybe this is necessary now given that we already set the Weave username when creating the profile on the Python side to `dummy`. An initial login will fail and later calls to Weave.Service.Login() no longer sends the notification. So what we might have to do is to already set the correct Weave credentials as preferences before starting up Firefox. The question is how important that is and how long we want to keep the old sync code tested. If that's not that long, I wouldn't be hesitated to leave it in for now. It's well tested from the past, and it doesn't hurt us for Firefox Accounts. Edwin, what is your feeling?

Sync 1.1 will be deprecated by fx32. If keeping support for sync 1.1 becomes a burden, let's drop it. We can always sync m-c to an old time stamp and test there. We should move fast versus getting dragged down by sync 1.1.

We still have support for Sync v1.1, but given your reply we might not want to spend more time on fixing that old code. It indeed doesn't make sense. Lets revisit this bug when necessary at this time, or if we detect issues earlier on.

Sync 1.1 support has been removed from Firefox, and from TPS, too, I think.