Jan-Ivar Bruaroey [:jib] (needinfo? me) Assignee
	Description • 10 years ago

Bug 907352 added code that supports backwards compatible constraints for mobile. The intent was to keep this in for one release to aid transition. This bug is filed as a reminder to remove it.

	Jan-Ivar Bruaroey [:jib] (needinfo? me) Assignee
	Comment 1 • 10 years ago

We can keep this around longer if need be (e.g. for Loop back-end). FYI:

> BACKWARDS-COMPATIBLE OLD FORMAT       | NEW FORMAT
> --------------------------------------+----------------------
> { optional: [{ facingMode:"user" }] } | { facingMode:"user" }
> { mandatory: { facingMode:"user" } }  | { facingMode:"user", require:"facingMode" }
> 

Again, the old format works only on B2G and Android.

	Jan-Ivar Bruaroey [:jib] (needinfo? me) Assignee
	Comment 3 • 10 years ago

Splinter helped me see I forgot to remove a file entirely.

	Martin Thomson [:mt:]
	Comment 4 • 10 years ago

Comment on attachment 8556720 [details] [diff] [review]
end support for hold-out mandatory/optional: facingMode constraint on mobile (2)

Review of attachment 8556720 [details] [diff] [review]:
-----------------------------------------------------------------

You need to start using reviewboard.  The UX sucks (apart from the bit where you push to create a review, that's nice), but it's still better than splinter...  In this case, I think that I'm going to trust you that the transplant of the common tests from constraints.js was correct.

::: dom/media/tests/mochitest/test_getUserMedia_constraints.html
@@ -25,4 @@
>  */
> -var desktop_tests = [
> -  { message: "legacy facingMode ignored (desktop)",
> -    constraints: { video: { mandatory: { facingMode:'left' } }, fake: true },

This is still probably a useful test to retain.  Even if 'mandatory' is just another 'somethingunknown', it still holds special meaning by virtue of having been something we respected at one time.

	Jan-Ivar Bruaroey [:jib] (needinfo? me) Assignee
	Comment 5 • 10 years ago

(In reply to Martin Thomson [:mt] from comment #4)
> You need to start using reviewboard.  The UX sucks (apart from the bit where
> you push to create a review, that's nice), but it's still better than
> splinter...  In this case, I think that I'm going to trust you that the
> transplant of the common tests from constraints.js was correct.

Trust and verify. :-) Here's a diff against constraints.js showing tests unharmed. Still comfy on the fence about reviewboard. It seems to be getting better though.

> This is still probably a useful test to retain.  Even if 'mandatory' is just
> another 'somethingunknown', it still holds special meaning by virtue of
> having been something we respected at one time.

I almost left it in there, so, sure.

	Martin Thomson [:mt:]
	Comment 6 • 10 years ago

Note, I'm going to bitrot your patch when I disable the _mobile test to address bug 1063290.

	Jan-Ivar Bruaroey [:jib] (needinfo? me) Assignee
	Comment 7 • 10 years ago

Incorporate feedback. Carrying forward r=smaug, mt.

	Carsten Book [:Tomcat]
	Comment 8 • 10 years ago

jib: can you post a try link here thanks!

	Jan-Ivar Bruaroey [:jib] (needinfo? me) Assignee
	Comment 9 • 10 years ago

Green try - https://treeherder.mozilla.org/#/jobs?repo=try&revision=65688f856328

	Ryan VanderMeulen [:RyanVM]
	Comment 10 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/ae5b86a2529d

	Ryan VanderMeulen [:RyanVM]
	Comment 11 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/ae5b86a2529d

	Eric Shepherd [:sheppy]
	Comment 12 • 9 years ago

Docs need to reflect this change in the appropriate places.

	Jan-Ivar Bruaroey [:jib] (needinfo? me) Assignee
	Comment 13 • 9 years ago

Note that this bug is over a year old, and the information is outdated. As of 38, Firefox follows the spec and no longer uses the require keyword mentioned in comment 1.

BACKWARDS-COMPATIBLE OLD FORMAT        | SPEC (38+)
---------------------------------------+----------------------
{ optional: [{ facingMode: "user" }] } | { facingMode: "user" }
                                       | { facingMode: { ideal: "user" } }
{ mandatory: { facingMode: "user" } }  | { facingMode: { exact: "user" } }

See also http://stackoverflow.com/questions/28282385/webrtc-firefox-constraints/28911694#28911694