Closed
Bug 997622
Opened 11 years ago
Closed 11 years ago
[markup view] Expand all descendants on Alt+Click
Categories
(DevTools :: Inspector, defect)
DevTools
Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 31
People
(Reporter: pbro, Assigned: pbro)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
jwalker
:
review+
|
Details | Diff | Splinter Review |
I just realized Chrome DevTools have this awesome sort-of-hidden feature where if you alt+click a node in the markup panel, not only the node with expand, but all of its descendants too.
It's super easy to do in the Firefox Devtools too, because we already have the function that does it: MarkupView.expandAll(node). By the way that function doesn't seem to be used anywhere.
Assignee | ||
Comment 2•11 years ago
|
||
This time with tests, and a try build: https://tbpl.mozilla.org/?tree=Try&rev=6b1aae0ba9cb
Attachment #8408054 -
Attachment is obsolete: true
Attachment #8408091 -
Flags: review?(jwalker)
Updated•11 years ago
|
Attachment #8408091 -
Flags: review?(jwalker) → review+
Comment 3•11 years ago
|
||
Comment on attachment 8408091 [details] [diff] [review]
bug997622-expand-all-markupview v2.patch
Review of attachment 8408091 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/devtools/markupview/markup-view.js
@@ +1418,5 @@
>
> _onToggle: function(event) {
> this.markup.navigate(this);
> if(this.hasChildren) {
> + this.markup.setNodeExpanded(this.node, !this.expanded, event.altKey);
Note: on windows/linux I believe it is CTRL + ALT + Click.
Assignee | ||
Comment 4•11 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #3)
> Note: on windows/linux I believe it is CTRL + ALT + Click.
That's correct, although I don't understand why. It feels simpler to have alt+click on all platforms, and I don't think alt+click is already bound to any other action.
Comment 5•11 years ago
|
||
(In reply to Patrick Brosset [:pbrosset] [:patrick] from comment #4)
> (In reply to Brian Grinstead [:bgrins] from comment #3)
> > Note: on windows/linux I believe it is CTRL + ALT + Click.
> That's correct, although I don't understand why. It feels simpler to have
> alt+click on all platforms, and I don't think alt+click is already bound to
> any other action.
As we discussed, listening for alt+click will also catch alt+ctrl+click anyway. So this should be good to go as-is.
Assignee | ||
Comment 6•11 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
Comment 8•11 years ago
|
||
Will, we've added a new shortcut on the markup view that allows expanding all child nodes by alt+clicking on the little arrow next to the node.
Keywords: dev-doc-needed
Updated•10 years ago
|
Keywords: dev-doc-needed → dev-doc-complete
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•