Closed
Bug 997996
Opened 11 years ago
Closed 11 years ago
Make ToolbarComponent.dismissEditingMode use the cancel editing mode button
Categories
(Firefox for Android Graveyard :: Testing, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 31
People
(Reporter: mcomella, Assigned: vivek)
References
Details
(Whiteboard: [mentor=mcomella][lang=java])
Attachments
(1 file)
|
(deleted),
patch
|
mcomella
:
review+
|
Details | Diff | Splinter Review |
Hit the url, hit the X, make sure editing mode is cancelled.
|
Reporter | |
Comment 1•11 years ago
|
||
Note that if bug 997447 is not implemented yet, this test will need to be guarded to run on phones only.
Since this method of dismissing editing mode is preferable to the one in ToolbarComponent.dismissEditingMode, use the cancel button there, and add a test for the current methodology instead of what comment 0 declares.
Summary: Add cancel editing mode button test → Make ToolbarComponent.dismissEditingMode use the cancel editing mode button
|
Assignee | |
Comment 2•11 years ago
|
||
I would like to work on this
|
|
Reporter | |
Comment 3•11 years ago
|
||
Sure - you've been assigned! The information in comment 0 and comment 1 should be enough to complete this bug. If anything is unclear or insufficient, please let me know!
Good luck!
Assignee: nobody → vivekb.balakrishnan
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•11 years ago
|
||
As per discussion over irc, ToolbarComponent.dismissEditingMode uses the close button in phones. existing method of hitting Back button twice retained for tablets.
Attachment #8409812 -
Flags: review?(michael.l.comella)
|
|
Reporter | |
Comment 5•11 years ago
|
||
Comment on attachment 8409812 [details] [diff] [review]
997996.patch
Review of attachment 8409812 [details] [diff] [review]:
-----------------------------------------------------------------
Nice, lgtm!
Do you mind following a dependent followup for implementing this on tablet, and CCing me? :)
Attachment #8409812 -
Flags: review?(michael.l.comella) → review+
|
|
Reporter | |
Updated•11 years ago
|
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 6•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [mentor=mcomella][lang=java] → [mentor=mcomella][lang=java][fixed-in-fx-team]
|
||
Comment 7•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [mentor=mcomella][lang=java][fixed-in-fx-team] → [mentor=mcomella][lang=java]
Target Milestone: --- → Firefox 31
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•