Closed
Bug 998042
Opened 11 years ago
Closed 9 years ago
Skia does not 4 byte align alpha surfaces which breaks interop with cairo
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: lsalzman)
References
Details
Attachments
(1 file, 3 obsolete files)
|
(deleted),
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Updated•11 years ago
|
Blocks: skia-reftest
|
|
Reporter | |
Comment 1•11 years ago
|
||
|
|
Reporter | |
Comment 2•11 years ago
|
||
This avoids breaking one of skia's assumptions. There might be more than this.
Instead of patching skia it might be better to just do allocations manually when constructing skia drawtargets. This should take care of all or most of the interop cases and does not break any of skia's assumptions.
Attachment #8408583 -
Attachment is obsolete: true
|
||
Updated•11 years ago
|
Whiteboard: [skia-upstream]
|
|
Reporter | |
Comment 3•11 years ago
|
||
|
|
Reporter | |
Updated•11 years ago
|
Assignee: nobody → jmuizelaar
|
Assignee | |
Comment 4•9 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #3)
> Created attachment 8418363 [details] [diff] [review]
> An attempt at this that doesn't change skia
This version of the patch that just works within DrawTargetSkia is safe as far as I can see. I have been testing with it locally for months. As a bonus, it is non-invasive and requires no effort to upstream, since it just works within out code. I think we should just go ahead and checkin this to get it out of the way. Is that okay?
Flags: needinfo?(jmuizelaar)
Probably needs some rebasing...
|
|
Assignee | |
Comment 7•9 years ago
|
||
This is a rebased and cleaned up version of Jeff's patch to work against our current tree Skia.
Assignee: jmuizelaar → lsalzman
Attachment #8411052 -
Attachment is obsolete: true
Attachment #8418363 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8671453 -
Flags: review?(jmuizelaar)
|
|
Reporter | |
Updated•9 years ago
|
Attachment #8671453 -
Flags: review?(jmuizelaar) → review+
|
|
Assignee | |
Comment 8•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
Whiteboard: [skia-upstream]
Keywords: checkin-needed
|
||
Comment 11•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•