Closed Bug 999213 Opened 11 years ago Closed 11 years ago

Cycle collect TabChildBase and remove weak reference scheme

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla31

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(3 files)

Part 1 - Make TabChildBase implement nsISupports and cycle-collect it. v1
(deleted), patch
smaug
: review+
Details | Diff | Splinter Review
Part 2 - Make TabChildGlobal::mTabChild a strong reference and cycle-collect it. v1
(deleted), patch
smaug
: review+
Details | Diff | Splinter Review
Part 3 - Remove now-unnecessary cleanup logic in ~TabChild. v1
(deleted), patch
smaug
: review+
Details | Diff | Splinter Review
This is basically the same as bug 998377, but for the OOP version of the code.
CCing tatiana given bug 985817, so that she knows this is happening.
(In reply to Bobby Holley (:bholley) from comment #1) > https://tbpl.mozilla.org/?tree=Try&rev=989de16718e2 This is green. The xpcshell oranges here are related to the patches from bug 997440, which rode along in the try push. Uploading patches and flagging for review.
Attachment #8410022 - Flags: review?(bugs) → review+
Attachment #8410023 - Flags: review?(bugs) → review+
Attachment #8410024 - Flags: review?(bugs) → review+
TabChild should have been made cycle collected, too. Instead it is replacing the refcount of TabChildBase and not calling cycle collected AddRef and Release.
Yup. /me kicks himself. It is way too easy to re-declare mRefCnt member variable.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: