Closed
Bug 999913
Opened 11 years ago
Closed 11 years ago
Enable replace-malloc on nightly builds
Categories
(Core :: Memory Allocator, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8410749 -
Flags: review?(mshal)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Comment 2•11 years ago
|
||
Comment on attachment 8410749 [details] [diff] [review]
Enable replace-malloc on nightly builds
Looks fine. A comment explaining why we want this on for nightly by default would be nice, though.
Attachment #8410749 -
Flags: review?(mshal) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Assignee | ||
Comment 4•11 years ago
|
||
Backed out because of the conflict with trace-malloc on debug builds, and the lack of jemalloc on x86 part on osx universal builds.
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf7655b24009
So this means the dependency on 999869 is backwards.
Assignee | ||
Comment 5•11 years ago
|
||
So, now that tracemalloc is disabled on debug builds, we can actually enable replace malloc without waiting on something else. It would be nice if it worked without jemalloc too, but it's good enough if it covers all platforms except 32-bits osx.
Attachment #8426036 -
Flags: review?(mshal)
Assignee | ||
Updated•11 years ago
|
Attachment #8410749 -
Attachment is obsolete: true
Updated•11 years ago
|
Attachment #8426036 -
Flags: review?(mshal) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Comment 7•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•