Closed
Bug 1003771
Opened 11 years ago
Closed 11 years ago
[Build System] Move out distribution_tablet/homescreen.json
Categories
(Firefox OS Graveyard :: Gaia::Build, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: chens, Assigned: chens)
References
Details
Attachments
(2 files, 1 obsolete file)
As 'distribution_tablet' folder will be removed in bug 996461, homescreen.json needs to move to a proper place. gaia/apps/homescreen/build/tablet/ could be the option.
|
Assignee | |
Comment 1•11 years ago
|
||
Hi Yuren,
I'm currently working on this but not sure is this the right direction to go, could you take a look at the WIP and give some feedback? Thanks.
Assignee: nobody → shchen
Attachment #8415321 -
Flags: feedback?(yurenju.mozilla)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8415321 [details]
WIP
Chens, you should just add GAIA_DEVICE_TYPE to BUILD_CONFIG in Makefile and use |APP_DIR| & |GAIA_DEVICE_TYPE| to assemble configuration path in javascript like
by nsIFile:
> var configDIR = utils.getFile(options.APP_DIR, 'build', options.GAIA_DEVICE_TYPE);
or by String:
> var configPath = utils.joinPath(options.APP_DIR, 'build', options.GAIA_DEVICE_TYPE);
Attachment #8415321 -
Flags: feedback?(yurenju.mozilla)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Hi Yuren,
Here's another WIP, app config path is built with |APP_DIR| & |GAIA_DEVICE_TYPE|. And the settings will be extent instead overwrite, how do you think?
Attachment #8415321 -
Attachment is obsolete: true
Attachment #8417244 -
Flags: feedback?(yurenju.mozilla)
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8417244 [details]
WIP
looks good and I suggest using |if (config.GAIA_DEVICE_TYPE)| instead of |if (config.GAIA_DEVICE_TYPE !== '')|
Attachment #8417244 -
Flags: feedback?(yurenju.mozilla) → feedback+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Attachment #8417840 -
Flags: review?(yurenju.mozilla)
|
|
||
Comment 6•11 years ago
|
||
Comment on attachment 8417840 [details]
Pull request
r=yurenju, thanks!
Attachment #8417840 -
Flags: review?(yurenju.mozilla) → review+
|
|
Assignee | |
Comment 7•11 years ago
|
||
Merged to master, r=yurenju
https://github.com/mozilla-b2g/gaia/commit/e911619c22dfad8555d427b917491f5cba1fc9c0
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•